Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running vs where -version [...] always shows an empty list #73

Closed
kzu opened this issue Jan 21, 2021 · 0 comments
Closed

Running vs where -version [...] always shows an empty list #73

kzu opened this issue Jan 21, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@kzu
Copy link
Member

kzu commented Jan 21, 2021 •
edited by devlooped-bot
Loading

There is an issue in how we parse the --version, which causes no installations to be found.

Back this issue
Back this issue
@kzu kzu added the bug Something isn't working label Jan 21, 2021
kzu added a commit that referenced this issue Jan 31, 2021
@kzu
Reintroduce --version option in a vswhere-compatible way
0535c19 
We had disabled this in  9093d5a because it previously interfered with the ability to run vs where with a version specifier.

We now instead check that the version is defined as the *first* argument specified, which covers that and makes it so that only `vs --version` will show it.

Fixes #72 and #73
kzu added a commit that referenced this issue Jan 31, 2021
@kzu
Reintroduce --version option in a vswhere-compatible way
a39b96b 
We had disabled this in  9093d5a because it previously interfered with the ability to run vs where with a version specifier.

We now instead check that the version is defined as the *first* argument specified, which covers that and makes it so that only `vs --version` will show it.

Fixes #72, #73
@kzu kzu closed this as completed in 5f48fce Jan 31, 2021
@devlooped devlooped locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kzu