Replaced Command.CancelAsync with AsyncDisposable pattern #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzu
reviewed
May 25, 2020
There was a problem hiding this comment.
Looking at the implementation now, I wonder if we shouldn't also support IDisposable for cancellations that don't require async work to cleanup (i.e. you're killing the Server process but not waiting for it to die, synchronously or asynchronously, meaning being "async" in that case is pointless...
adalon
force-pushed
the
dev/adalon/AsyncDisposable
branch
2 times, most recently
from
d726815 to
e21d577
Compare
kzu
approved these changes
May 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.