Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce --version option in a vswhere-compatible way #74

Merged
merged 1 commit into from
Jan 30, 2021
Merged

Reintroduce --version option in a vswhere-compatible way #74

merged 1 commit into from
Jan 30, 2021

Conversation

kzu
Copy link
Member

@kzu kzu commented Jan 30, 2021

We had disabled this in 9093d5a because it previously interfered with the ability to run vs where with a version specifier.

We now instead check that the version is defined as the first argument specified, which covers that and makes it so that only vs --version will show it.

Fixes #72

@kzu
Reintroduce --version option in a vswhere-compatible way
49e2254 
We had disabled this in  9093d5a because it previously interfered with the ability to run vs where with a version specifier.

We now instead check that the version is defined as the *first* argument specified, which covers that and makes it so that only `vs --version` will show it.

Fixes #72
@kzu kzu requested a review from adalon January 30, 2021 02:02
@kzu kzu enabled auto-merge (rebase) January 30, 2021 02:02
@kzu kzu merged commit abf6226 into main Jan 30, 2021
@kzu kzu deleted the version branch January 30, 2021 02:06
@devlooped devlooped locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adalon adalon Awaiting requested review from adalon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow rendering tool version with --version
1 participant
@kzu