Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Sponsorable Attribute in release v4.20.71 #1513

Closed
tomvdk opened this issue Sep 5, 2024 · 1 comment · Fixed by #1515
Closed

Question: Sponsorable Attribute in release v4.20.71 #1513

tomvdk opened this issue Sep 5, 2024 · 1 comment · Fixed by #1515
Labels

Comments

@tomvdk
Copy link

tomvdk commented Sep 5, 2024

Hi @kzu ,

First of all, thank you for your work on Moq.

We've noticed in release v4.20.71, you've added an attribute Sponsorable. This raised a few questions at our company:

  1. Could you please explain the intend of this as it appears it is not used anywhere for now?
  2. How will you determine or will determine if a user is a sponsor?

[assembly: Sponsorable(60)]
namespace Moq
{
class SponsorableAttribute : Attribute
{
public SponsorableAttribute() { }
public SponsorableAttribute(int days) { }
}
}

Thanks for your answers.

Back this issue
Back this issue

@tomvdk tomvdk changed the title Question: IsSponsor Attribute in release v4.20.71 Question: Sponsorable Attribute in release v4.20.71 Sep 5, 2024
kzu added a commit that referenced this issue Sep 7, 2024
This was an unintended addition.

Fixes #1513
@kzu kzu closed this as completed in #1515 Sep 7, 2024
@kzu kzu closed this as completed in 959fc51 Sep 7, 2024
@kzu
Copy link
Member

kzu commented Sep 7, 2024

I have unlisted that version and .72 should be out momentarily without that unused attribute. Thanks for spotting it :)

@kzu kzu added the question label Sep 7, 2024
@devlooped devlooped locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants