Make interface proxy creation twice as fast #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating proxies with DynamicProxy is the single most expensive kind of operation that Moq does. Commit 54e132b changed how proxies for interface types are generated so that `object` methods on interfaces could also be intercepted (and thus set up). Unfortunately, this change also made interface proxy generation twice as costly! This commit restores the previous method for interface proxy creation, and at the same time adds an `InterfaceProxy` class to keep `object` methods interceptable.
stakx
force-pushed
the
interface-proxies
branch
from
a503e7b to
9c24816
Compare
stakx
commented
Dec 11, 2017
| // It is public because it needs to be visible to the framework's types in `Reflection.Emit`. | ||
| // Not sure what `[assembly: InternalsVisibleTo(<some framework assembly>)]` would have to look like. | ||
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| public abstract class InterfaceProxy |
There was a problem hiding this comment.
It's a pity this internal type needs to be public for now. See #98 and https://stackoverflow.com/q/47761193/240733.
| { | ||
| // Forward this call to the interceptor, so that `object.Equals` can be set up. | ||
| var invocation = new Invocation(equalsMethod, obj); | ||
| ((IInterceptor)((IMocked)this).Mock).Intercept(invocation); |
There was a problem hiding this comment.
When an object method is invoked on an interface proxy object, DynamicProxy will be bypassed, and we'll end up here, in the base class. The Mock.Intercept(Invocation) method doesn't care who intercepted a method, so we can just create an Invocation representing the object method call, and send it off to be intercepted.
| using System.Diagnostics; | ||
| using System.Reflection; | ||
|
|
||
| namespace Moq.Internals |
There was a problem hiding this comment.
Let's try not to pollute the Moq namespace with something that should be internal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating proxies with DynamicProxy is the single most expensive kind of operation that Moq does. Commit 54e132b changed how proxies for interface types are generated so that
objectmethods on interfaces could also be intercepted (and thus set up). Unfortunately, this change also made interface proxy generation twice as costly!This commit restores the previous method for interface proxy creation, and at the same time adds an
InterfaceProxyclass to keepobjectmethods interceptable.This should bring Moq's performance back to, or very close to, what it used to be before version 4.5.16.
/cc #504, #491