Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to .net standard 2.0 #646

Closed
wants to merge 2 commits into from
Closed

migrate to .net standard 2.0 #646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b17109f
migrate to .net standard 2.0
Jul 19, 2018
8f2b6c2
fix 2.0.0
Jul 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Moq.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@
<dependency id="System.Threading.Tasks.Extensions" version="4.3.0" />
<dependency id="System.ValueTuple" version="4.4.0" />
</group>
<group targetFramework=".NETStandard2.0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do indeed target netcoreapp2.x instead the dependencies will likely look a bit more minimal. This will likely need to be changed. Stay tuned for more feedback later.

<dependency id="NETStandard.Library" version="2.0.0" />
<dependency id="System.Linq.Queryable" version="4.3.0" />
<dependency id="System.Reflection.Emit" version="4.3.0" />
<dependency id="System.Reflection.TypeExtensions" version="4.3.0" />
<dependency id="Castle.Core" version="4.3.1" />
<dependency id="System.Threading.Tasks.Extensions" version="4.3.0" />
<dependency id="System.ValueTuple" version="4.4.0" />
</group>
</dependencies>
</metadata>
<files>
Expand All @@ -36,5 +45,8 @@
<file src="Source\bin\$configuration$\netstandard1.3\Moq.dll" target="lib\netstandard1.3" />
<file src="Source\bin\$configuration$\netstandard1.3\Moq.pdb" target="lib\netstandard1.3" />
<file src="Source\bin\$configuration$\netstandard1.3\Moq.xml" target="lib\netstandard1.3" />
<file src="Source\bin\$configuration$\netstandard2.0\Moq.dll" target="lib\netstandard2.0" />
<file src="Source\bin\$configuration$\netstandard2.0\Moq.pdb" target="lib\netstandard2.0" />
<file src="Source\bin\$configuration$\netstandard2.0\Moq.xml" target="lib\netstandard2.0" />
</files>
</package>
2 changes: 1 addition & 1 deletion Source/Moq.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net45;netstandard1.3</TargetFrameworks>
<TargetFrameworks>net45;netstandard2.0</TargetFrameworks>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We first need to decide which frameworks we want to target before dropping older versions. This will likely need to be changed. I'll give you further feedback once we've figured out things.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to support the latest netstandard2.0 version in order to use it at .net core 2.x projects and also the previous versions if it's possible.

<AssemblyName>Moq</AssemblyName>
<AssemblyOriginatorKeyFile>../Moq.snk</AssemblyOriginatorKeyFile>
<DebugSymbols>True</DebugSymbols>
Expand Down