Skip to content

Carousel not destroying properly when settings object is updated. #113

Open
@decodedcreative

Description

@decodedcreative

Hi,

There however seems to be a bug with the plugin where its destroy method does not properly remove slides from the carousel instance.

angular-slick.js has the following Angular Watch which is triggered every time a change is made to the settings object:

return scope.$watch('settings', function (newVal, oldVal) { if (newVal !== null) { return destroyAndInit(); } }, true);

My carousel initially loads with 15 slides and every time the destroyAndInit function is run, another 15 slides are erroneously added to the carousel. Because of this I suspect the destroy function is not working as expected. Here is the code for it:

` destroy = function () {

    var slickness = angular.element(element);
    if (slickness.hasClass('slick-initialized')) {
      slickness.remove('slick-list');
      slickness.slick('unslick');
    }

    return slickness;
  };`

Any ideas?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions