support item props for custom #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for contribution. |
|
it's published here v1.0.4 https://www.npmjs.com/package/@devmehq/open-graph-extractor |
|
Thanks!!! |
|
Thank you, I have also added test with the url you mentioned above and push the version 1.0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome library! This is my first PR to a public repo so I hope it worked ok :)
The change intends to include
itemPropattribute on meta tags, which didn't appear to be supported. I've been testing with this site: https://www.net-a-porter.com/en-au/shop/product/gucci/shoes/mid-heel/plastique-logo-embossed-rubber-mules/1647597276960849It looks like you currently use itemprop only as a fall back, but when using custom tags this didn't seem to work. As such, I've added this to the src file. Thanks!