Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-source input (Issue #33) #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dobon
Copy link

@dobon dobon commented Sep 17, 2018

  • Add support for multi-source input via using an array of specially formulated objects as input.
  • Add spec to test multi-source input covering use of 'page', 'toc' and 'cover' page types, global options, optional arguments and page-specific options. I think this is fairly complete, but more tests could be added.
  • Update README.md to explain how to use multi-source input.
  • Refactor the options-to-arguments part of code into a helper function for reuse in both single and multi-source input use cases.
  • Refactor code location of array of valid ToC options and added array of valid global options. This could be extended to include header and footer options, and page-specific options, and could then be used to validate options.

@dobon
Copy link
Author

dobon commented Sep 17, 2018

@devongovett Can someone help me debug why this PR failed the CI test? npm test passes fine on my development environment using wkhtmltopdf 0.12.2.1 (with patched qt) on OSX 10.13.6. I am happy to provide any details that will help.

@zxlin
Copy link
Collaborator

zxlin commented Feb 27, 2021

@dobon travis was fixed, can you rebase this with master and let it run thru travis again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants