Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newline handling if using commit_prefix or commit_message #75

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 10, 2022

📝 Brief description

Fix newline handling if using commit_prefix or commit_message

💻 Commits

  • 398d405 - Krzysztof Szyper - 2022-11-10 13:37:43
    Fix newline handling if using commit_prefix or commit_message
    git commit in Ubuntu is not handling stroke the same way as Alpine.
    Using echo -e will normalize this.
    This wasn't an issue on Alpine.

    Added also newline handling to files_changed just in case.

📁 Modified files

entrypoint.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

⚠️ Additional information

  • Pushed to a branch with a proper name and provided proper commit message.
  • Provided a clear and concise description of what the issue is.

Check CONTRIBUTING.md and CODE_OF_CONDUCT.md for more information

`git commit` in Ubuntu is not handling `\n` stroke the same way as Alpine.
Using `echo -e` will normalize this.
This wasn't an issue on Alpine.

Added also newline handling to `files_changed` just in case.
@github-actions github-actions bot requested review from ChristophShyper and a team as code owners November 10, 2022 12:38
@github-actions github-actions bot added the bugfix Bug needing a fix label Nov 10, 2022
@ChristophShyper ChristophShyper merged commit 649bcb8 into master Nov 10, 2022
@ChristophShyper ChristophShyper deleted the bugfix/newline branch November 10, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug needing a fix
Development

Successfully merging this pull request may close these issues.

1 participant