git not handling unchanged files properly

[jevalenciap]

I tested the Github action against HachiCorp Vault policy files, since it detects the formatting errors in the policies, then it failed because doesn't find tf and tfvars.

=> Searching for .tf and .tfvars files
error: unknown option `staged'

Wanted to see if you can include HCL Vault policies in the action or see if I can omit the step about searching .tf and .tfvars files in order to work with Vault.

[ChristophShyper]

@jevalenciap Which version of the action are you using?
git diff --staged was used here in versions prior to v0.3.
Please update it and let me know the result.

[jevalenciap]

Thanks @ChristophShyper for your prompt response.
I am using V0.3

- name: Fail on malformatted files
        uses: devops-infra/action-format-hcl@v0.3
        with:
          list: true

It detects formatting issues correcly in the Vault HCL policies but then I got an error.
Adding a screenshot of the error that I am getting:
Not sure if the error is because tf and tfvars files are not found (since they are only applicable for Terraform but not for Vault)

[ChristophShyper]

@jevalenciap I found the issue. Due to how GitHub Actions are constructed the version needs to be always updated in the manifest file. Which I somehow missed for the last release. As a result, even if you had v0.3 in your workflow it still used the image with v0.2.
This line needed to be updated https://github.com/devops-infra/action-format-hcl/pull/70/files#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R38
I'll release v0.3.1 now which should work properly.

[jevalenciap]

Thanks @ChristophShyper, I updated the GH action to the version 0.3.1

- name: Fail on malformatted files
        uses: devops-infra/action-format-hcl@v0.3.1
        with:
          list: true

But now I am getting a cache error once GH action runs.

[ChristophShyper]

Looks like git even on Ubuntu acts different than on my host and in some cases (issue with .git) it throws this error.
So from now I'll use find instead of it, while maintaining similar functionality.
This change should do the trick https://github.com/devops-infra/action-format-hcl/pull/71/files#diff-6f9d41d046756f0ddc2fcee0626bdb50100d12b88f293734eff742818e03efa2R58

I'm releasing it with v0.3.3 version together with newest Terraform.

[jevalenciap]

@ChristophShyper
Great!, I tested it, I am not getting the error anymore.

Thank you so much! I appreciate your diligence and fast response

[ChristophShyper]

I'm happy my work is of any help to others 😃