Ability to specify disallowed qualities in quality profiles is required

[francoiseger]

Sonarr/Sonarr#6005 means that it is necessary that all qualities are always specified in quality profiles, even if they are potentially disallowed. Missing qualities is not equivalent to them being disallowed.

More generally it would be nice if one did not have to specify the default values for all custom formats and quality profiles manually every time they are used but that the module would take care of that.

[Fuochi]

This is really interesting. I genuinely thought that a missing quality would've been treated in the same way as a not allowed quality. But I hadn't look at the code, my bad.
This will require quite some changes, both here and in the TF providers. I could probably fetch the whole list from the /qualityprofile/schema endpoint, but it'll still become a bit challenging when the user is changing any quality group. Another option could be to fetch the list from /qualitydefinition, and then add all the missing ones both disallowed, and without group.
I'll put this in my backlog, but honestly, I don't know when I'll be able to address it. Probably not in September, sorry.

[Fuochi]

Hi @francoiseger,
this should be fixed in v1.1.1. Now all quality profiles are added, custom formats as well.
I'll still be open for improvement if you want to continue with #69, feel free to rebase. If you continue I'll check again the PR once the tests are green

[francoiseger]

Hey, sorry about the radio silence, I was a little preoccupied. I'll continue to look into #69, but FYI 1.1.1 doesn't seem to have been published the galaxy properly yet? Might be that one of the workflows isn't doing what it should be.

[Fuochi]

No problem, thanks for giving me the heads up on the published version. It seems I'm not the only one who encountered this problem ansible/galaxy#1980 It's probably related to Galaxy migration, I'll check as soon as I can.