Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting a timeout on the API client rather than individual API function calls #11

Closed
Callum027 opened this issue Apr 16, 2023 · 2 comments
Closed

Setting a timeout on the API client rather than individual API function calls #11

Callum027 opened this issue Apr 16, 2023 · 2 comments

Comments

@Callum027
Copy link

Hi there,

Is there a way to set a default _request_timeout on the ApiClient object, or perhaps the Configuration object that gets passed to it?

I'd like to set a standard timeout for all API requests I make, but from what I can see in the source and docs, the only way to set it right now is to pass _request_timeout=<timeout> for each request call.

This is a lot of work when making a lot of API calls so I was wondering if there was a simpler/more convenient way of doing it.
@Callum027 Callum027 changed the title Setting a timeout on the API client Setting a timeout on the API client rather than individual API function calls Apr 16, 2023
@Fuochi
Copy link
Contributor

Fuochi commented Apr 25, 2023

Hi @Callum027,
Sorry for my late reply. You are right, at this moment the request timeout is managed in each method.
I think your request does make sense. I'll add this to the Configuration object, but It could take few weeks.

Fuochi added a commit to devopsarr/sdk-generator that referenced this issue May 17, 2023
@Fuochi
feat(devopsarr/prowlarr-py#11): add request timeout to config
c0b1b0e
devopsarr bot added a commit that referenced this issue May 17, 2023
@devopsarr
feat(#11): add request timeout to config
046bdfb
devopsarr bot added a commit to devopsarr/lidarr-py that referenced this issue May 17, 2023
@devopsarr
feat(devopsarr/prowlarr-py#11): add request timeout to config
9cfee60
devopsarr bot added a commit to devopsarr/whisparr-py that referenced this issue May 17, 2023
@devopsarr
feat(devopsarr/prowlarr-py#11): add request timeout to config
cb0192b
devopsarr bot added a commit to devopsarr/sonarr-py that referenced this issue May 17, 2023
@devopsarr
feat(devopsarr/prowlarr-py#11): add request timeout to config
ff03ca7
devopsarr bot added a commit to devopsarr/radarr-py that referenced this issue May 17, 2023
@devopsarr
feat(devopsarr/prowlarr-py#11): add request timeout to config
87eb757
devopsarr bot added a commit to devopsarr/readarr-py that referenced this issue May 17, 2023
@devopsarr
feat(devopsarr/prowlarr-py#11): add request timeout to config
04646e9
Fuochi added a commit to devopsarr/sdk-generator that referenced this issue May 17, 2023
@Fuochi
Merge pull request #21 from devopsarr/feature/devopsarr/prowlarr-py#11
d7bbe60 
feat(devopsarr/prowlarr-py#11): add request timeout to config
devopsarr bot added a commit that referenced this issue May 17, 2023
@devopsarr
Merge pull request #16 from devopsarr/feature/code-generation
d61cca0 
feat(#11): add request timeout to config
devopsarr bot added a commit to devopsarr/readarr-py that referenced this issue May 17, 2023
@devopsarr
Merge pull request #13 from devopsarr/feature/code-generation
d33a296 
feat(devopsarr/prowlarr-py#11): add request timeout to config
devopsarr bot added a commit to devopsarr/radarr-py that referenced this issue May 17, 2023
@devopsarr
Merge pull request #16 from devopsarr/feature/code-generation
4b9c94a 
feat(devopsarr/prowlarr-py#11): add request timeout to config
devopsarr bot added a commit to devopsarr/sonarr-py that referenced this issue May 17, 2023
@devopsarr
Merge pull request #21 from devopsarr/feature/code-generation
f4d7222 
feat(devopsarr/prowlarr-py#11): add request timeout to config
devopsarr bot added a commit to devopsarr/whisparr-py that referenced this issue May 17, 2023
@devopsarr
Merge pull request #15 from devopsarr/feature/code-generation
0aef256 
feat(devopsarr/prowlarr-py#11): add request timeout to config
devopsarr bot added a commit to devopsarr/lidarr-py that referenced this issue May 17, 2023
@devopsarr
Merge pull request #14 from devopsarr/feature/code-generation
9ed2146 
feat(devopsarr/prowlarr-py#11): add request timeout to config
This was referenced May 17, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@Fuochi
Copy link
Contributor

Fuochi commented May 29, 2023

closed with #14 it's now part of the Configuration object.
When you have both, the API call takes precedence.

@Fuochi Fuochi closed this as completed May 29, 2023
This was referenced Feb 19, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Callum027 @Fuochi