Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

Logo images are not constrained on small viewports #384

Closed
mattstratton opened this issue Mar 16, 2017 · 1 comment
Closed

Logo images are not constrained on small viewports #384

mattstratton opened this issue Mar 16, 2017 · 1 comment
Assignees

Comments

@mattstratton
Copy link
Member

That image should not extend outside its parent container.

@mattstratton
Copy link
Member Author

Further review shows that this has other implications - when I opened this ticket, I was only looking at it on mobile.

The code for the image is this:

<img alt="devopsdays {{ $e.city }} {{ $e.year }}" src="/events/{{ $event_slug }}/logo.png" style="max-width: 90%; margin:5%;"/>

So since we are setting it to max-width of 90%, it's going to scale pretty big. What might work is to slightly refactor the the shortcode to put the image inside a div which constrains the width to a certain size.

What I am concerned about is people going quickly to change their images to be smaller, which is going to make them not look good on retina with our image processing. I'd like to fix this as soon as possible. I'll work on it today.

@ghost ghost assigned mattstratton Mar 16, 2017
@ghost ghost added the needs-review label Mar 16, 2017
@ghost ghost removed the needs-review label Mar 16, 2017
mattstratton added a commit that referenced this issue Mar 16, 2017
- Logo images are not constrained on small viewports  [\#384](#384)
- data cleanup for event\_twitter shortcode change [\#214](#214)
- Add regression testing to current site [\#55](#55)

Signed-off-by: Matt Stratton <matt.stratton@gmail.com>
mattstratton added a commit to devopsdays/devopsdays-web that referenced this issue Mar 16, 2017
**Closed issues:**

- Logo images are not constrained on small viewports  [\#384](devopsdays/devopsdays-theme#384)
- data cleanup for event\_twitter shortcode change [\#214](devopsdays/devopsdays-theme#214)
- Add regression testing to current site [\#55](devopsdays/devopsdays-theme#55)

Signed-off-by: Matt Stratton <matt.stratton@gmail.com>
mattstratton added a commit to devopsdays/devopsdays-web that referenced this issue Mar 16, 2017
* Remove old theme

Signed-off-by: Matt Stratton <matt.stratton@gmail.com>

* Release theme 1.0.2

**Closed issues:**

- Logo images are not constrained on small viewports  [\#384](devopsdays/devopsdays-theme#384)
- data cleanup for event\_twitter shortcode change [\#214](devopsdays/devopsdays-theme#214)
- Add regression testing to current site [\#55](devopsdays/devopsdays-theme#55)

Signed-off-by: Matt Stratton <matt.stratton@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant