-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SITE] add talk page #14346
base: main
Are you sure you want to change the base?
[SITE] add talk page #14346
Conversation
add a talk page based upon devopsdays#12515 * all talks, workshops and ignites get displayed on a single page * this page has the presentation title, the speakers, and when it is happening with the abstract * all speakers are also displayed, with their picture and bio Signed-off-by: Toshaan Bharvani <toshaan@vantosh.com>
✅ Deploy Preview for devopsdays-web ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
i think this is a good start! I would want to do a little bit more with the styling on this before merging it (the background color of each item is quite harsh, etc) but i think that with some visual style improvements this is a good one. |
Note: since it's not navigable, here's the direct link to deploy preview of a Talks page (for reference for other reviewers) https://deploy-preview-14346--devopsdays-web.netlify.app/events/2024-antwerp/talks/
|
OK, I am not a stylist, if you give me pointers, I can update the style or you can do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re styling, I'd like to see more padding in each container (probably 2em) to give more whitespace on the page. Color coding doesn't work well for accessibility reasons, so I'd try to find a different way to indicate type of talk. Italics also create problems for people who have reading issues (e.g., dyslexia). I can try to whip up some CSS for it, but I don't think reusing the styles from the program page will work since those really rely on having everything there without scrolling. If you can hang on for a few days, I'll see what I can mock up.
@nimbinatus Yes, this PR is not in a hurry, so if you can provide a mock up or any other additional feedback and information, that would be very helpful I like the idea of adding markers, for example some font-awesome icons, for talks, workshops and ignites, however I think we should have those consistent on the program, talk and speaker page. I also think that once we do figure out the move to |
@nimbinatus Any news on the mockup or CSS updates? |
I will try to take a look at mocking this up. |
Sorry, folks, dayjob inhaled my time. No updates. I'll be picking this up mid next week unless someone who has some available cycles wants to. |
add a talk page based upon #12515