Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIN-25] Announce 2025 edition #14768

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

sergiubodiu
Copy link
Contributor

[SIN-2025] Announce Dates and location
[SIN-2024] Add presentation decks and recorded videos.

@sergiubodiu sergiubodiu requested a review from a team as a code owner December 14, 2024 22:29
Copy link

netlify bot commented Dec 14, 2024

Deploy Preview for devopsdays-web ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 68a7207
🔍 Latest deploy log https://app.netlify.com/sites/devopsdays-web/deploys/675f74aff3f3bd00082da78d
😎 Deploy Preview https://deploy-preview-14768--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sergiubodiu
Copy link
Contributor Author

Let me know if you have any questions, we're announcing 2025 edition for 14-15 May, have a good weekend.

@sergiubodiu
Copy link
Contributor Author

Added the logo square using new format.

@toshywoshy
Copy link
Contributor

A note for future reference, it would better to have the 2024 updates/changes in a separate PR.
This would mean that that PR is not dependant on other changes.

@sergiubodiu
Copy link
Contributor Author

Moved static images to new assets folder. For clarification we closed 2024, added the video recordings and speaker decks, changed the wording showing that it was wrapped and are announcing the 2025 edition

Copy link
Contributor

@jyee jyee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything from @toshywoshy's review was corrected.
I left a couple minor notes. I don't think either are blocking, but worth flagging for @sergiubodiu.

registration_date_end: 2025-05-13T23:59:59+08:00 # close registration. Leave blank if registration is not open yet. If you set "registration_date_start" you need a value here.

registration_closed: "" #set this to true if you need to manually close registration before your registration end date
registration_link: "https://ti.to/devopsdays-singapore/2025/" # "" If you have a custom registration link, enter it here. This will control the Registration menu item as well as the "Register" button.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link gives a 404 error. Is it ready to go live once we merge the PR?
I don't think it should block the merge, but it should be corrected as soon as possible.


Find more facts about Singapore here:

https://en.wikipedia.org/wiki/Singapore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation here is probably not what you were intending, since that turns the text into a code block and they're not hyperlinked.

@toshywoshy toshywoshy merged commit b1e037a into devopsdays:main Dec 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants