-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LDN-2019] Change SheffieldDevops logo #7241
[LDN-2019] Change SheffieldDevops logo #7241
Conversation
If this logo has been used in the past, the old sponsor needs to be renamed and a new sponsor created. We do not allow retroactive changes. More details here: https://github.com/devopsdays/devopsdays-web/blob/master/utilities/README.md |
Makes sense @mattstratton. @chriscoffee want me to do the work on another PR you can pull in? |
It's cool @muggahtee, 62b2ef2 should hopefully be correct implementation if the maintainers want to have another peek 👍 Sorry it took me like ~40 minutes, I got dragged into 🔥 🚒 |
Right so after chatting to @MikeRosTX in Slack I didn't read the documentation as throughly as I should have... (we used another term for this 😄) I'll get this sorted now but for those who weren't privee and want to learn from my mistake, don't just skim https://github.com/devopsdays/devopsdays-web/blob/master/utilities/README.md#updating-a-sponsor and actually click the links and stuff and read #503 😆 |
Ah so old events need to have the renamed sponsor applied to them? |
Change to static elements of theme as SheffieldDevops logo has changed Co-authored-by: Oliver Leaver-Smith <oliver@leaversmith.com> Co-authored-by: Chris Mills <me@christophermills.co.uk
9fc949b
to
3029161
Compare
I've rebased to hide my shame
Edit: Also props for making me check with |
It's been a long day, apologies to all those involved! Signed-off-by: Chris M <me@christophermills.co.uk>
I can see the change live, thanks so much 🙌 |
Change to static elements of theme as SheffieldDevops logo has changed
Original PR was #7238 which was closed due to not being from an organizer and using correct guidelines
Co-authored-by: Oliver Leaver-Smith oliver@leaversmith.com
Co-authored-by: Chris Mills <me@christophermills.co.uk