Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relates to #298: Fix for ruby 3.x named parameter syntax changes. #300

Conversation

lamech
Copy link

@lamech lamech commented Jun 6, 2023

I've found all the incidences of the old named parameter syntax and updated them.

I've tested my fix (and others can run it, too, until there's a new release) using the "Testing" instructions under the contribute section of the docs.

This works for my Vagrant use case; I am able to vagrant up and get what I expect (see the README there), and vagrant destroy to throw it away, without encountering the error in #298.

Hope this helps!

@seth-reeser
Copy link
Member

Great, thank you @lamech. We'll take a look.

@utkonos
Copy link

utkonos commented Jun 14, 2023

This fixes the issue. Also, just editing the files that are changed by this PR in the following directory is sufficient until the maintainers are able to make the formal update: ~/.vagrant.d/gems/3.1.4/gems/vagrant-digitalocean-0.9.5/lib/vagrant-digitalocean/actions/

@utkonos
Copy link

utkonos commented Sep 2, 2023

@seth-reeser Do you plan on merging this PR? This vagrant provider plugin has been broken for a long time now.

@seth-reeser seth-reeser merged commit 69550d6 into devopsgroup-io:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants