Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LMStudio Model Selection #242

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

tobiashochguertel
Copy link
Contributor

I hope this is so far fine?

@stephanj
Copy link
Contributor

stephanj commented Aug 23, 2024

Great feature which almost works perfectly!

There's one corner case where when you stop the LMStudio server when IDEA is already running and select another LLM provider (for example Ollama) and then go back to LMStudio the "is LMStudio running" check is not executed again. As a result you'll get an exception.

Thanks for the effort, will definitely make it into the plugin!

Screenshot 2024-08-23 at 17 33 47

@stephanj
Copy link
Contributor

The model selection works and also the first time check if LMStudio is running.
Screenshot 2024-08-23 at 17 32 25
Screenshot 2024-08-23 at 17 34 09

@stephanj
Copy link
Contributor

BTW See also #234 maybe this is something you can easily pickup? 😅 #ThankYou

@tobiashochguertel
Copy link
Contributor Author

Hey @stephanj, thanks for your time to check my PR. 🍀🙏🏻👍

I will work tomorrow on your suggestions and fix the bug 🐛 and then I will work on getting the token usage into the response panel.

@stephanj stephanj merged commit 5fcc36e into devoxx:master Aug 28, 2024
stephanj added a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants