-
Notifications
You must be signed in to change notification settings - Fork 1
Implement log tagging for SDK logs #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1dcaaca to
9cd8095
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I don't understand this whole complexity behind. So, what we want achieve is just prefixing SDK logs with [SDK] or sth like that, and possibly user logs with [USER]. Most likely I don't understand security issues here, but seems a bit like an overkill to me and sth that can overcomplicate our lifes. Let's discuss this on call.
6c7d0fc to
51e57d8
Compare
52f571f to
87a94c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added few suggestions, will probably add more comments in second review. However, since logger overrides console, can we use console.log/error/warn... at all other places, let's have clear distinction here?
Also, let's ask @navneel99 for quick review after tomorrow's meeting.
7daa064 to
b3c3e74
Compare
b3c3e74 to
3ed821e
Compare
|
The code has been rewritten to support new linting addition. Functions inside of With the new changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added few comments, looks much better now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, please test in both local mode and on lambda.
Description
This PR changes how the SDK internal logs are printed. As it currently stands, the SDK logs are all prefixed with
SDK:.Connected Issues
Checklist
npm run testOR no tests needed.npm run test:backwards-compatibility.