Fix sending large messages to SQS queue #86
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the size reaches 80% of the 200KB size for the message, executes the "onTimeout" function and returns the PROGRESS event.
gasperzgonec
force-pushed
the
gasperz/ISS-214777
branch
from
9a97b88 to
5c9be86
Compare
src/common/event-size-monitor.ts
Outdated
| import { ErrorRecord } from '../types/common'; | ||
| import { EventData } from '../types/extraction'; | ||
|
|
||
| const MAX_EVENT_SIZE = 200_000; |
There was a problem hiding this comment.
Probably it is a good practice to put the unit too, so MAX_EVENT_SIZE_BYTES? Or not?
There was a problem hiding this comment.
You are correct.
Fixed.
src/common/event-size-monitor.ts
Outdated
| import { EventData } from '../types/extraction'; | ||
|
|
||
| const MAX_EVENT_SIZE = 200_000; | ||
| const SIZE_LIMIT_THRESHOLD = Math.floor(MAX_EVENT_SIZE * 0.8); // 160_000 bytes |
There was a problem hiding this comment.
EVENT_SIZE_THRESHOLD_BYTES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix limits the max amount of bytes to be sent to SQS to be 200kB, which resolves the issue with the events being comitted to SQS and failing because they surpass the 250kB limit.
Connected Issues
Checklist
npm run testOR no tests needed.npm run test:backwards-compatibility.no-docswritten: no-docs