Update specification to include attachments and rate limiting #7

patricijabrecko · 2025-10-08T11:36:48Z

No description provided.

wrike_postman.json

templates/incremental_mode_acceptance_tests.plain

devrev-wrike-snapin.plain

Co-authored-by: Tjaž Eržen <tjaz@codeplain.ai>

devrev-wrike-snapin.plain

tjazerzen

Looking better :). Providing complete context and avoid "guessing" is key to developing scalable integrations with plain. In some places, I saw missing context, and it's very important to address this before rendering.

mappings/external_domain_metadata_comments.plain

mappings/initial_domain_mapping_tasks.plain

mappings/initial_domain_mapping_comments.plain

wrike_postman.json

devrev-wrike-snapin.plain

wrike_postman.json

tjazerzen · 2025-10-09T12:58:26Z

devrev-wrike-snapin.plain

+- If "event_type" equals "EXTRACTION_DATA_START" or "EXTRACTION_DATA_CONTINUE" The Extraction Function should push the 'tasks' and 'users' data. To push the 'tasks' data, it should:
+  - If `TheExtractionStateObject["tasks"]["completed"]=false`:
+    - While Fetching The Fetched Tasks using pagination (The Tasks Iteration):
+      - When fetching The Fetched Tasks use the query param 'fields', where the value is an array of strings, which contains at least 'hasAttachments'.


I think this still have to be adjusted to comment made in the previous review iteration.

But I think this is described correctly - it has to at least contain 'hasAttachments', can also contain other values. Depends on the use case.

If I limit it here to contain only 'hasAttachments' it will be in conflict with other FRs.

I suggest you phrase which contains at least 'hasAttachments'. less ambiguously as we discussed, and render. I understand you got a conflict earlier. I think we should get to the root cause of the problem why a conflict exists, and then resolve it.

devrev-wrike-snapin.plain

tjazerzen

Alright 👍

Let's finish it tomorrow, but here are the things you can do right away:

final touches for mappings/ folder
Minor updates to test_data/ folder

Also, I'm missing the updates for the new templating:

every file from mappings/ folder
Correct templating of templates/chef_cli_normalization_validation.plain in devrev-wrike-snapin.plain

tjazerzen · 2025-10-13T11:47:19Z

mappings/external_domain_metadata_comments.plain

+    - Type of field author_id is an array with max_length 1, which can be used directly.
+  - task_id (display name: "Task ID", is required, type: reference)
+    - Field task_id refers to the record type "#record:tasks".
+    - Type of field task_id is an array with max_length 1, which can be used directly.


can be used directly

Let's be less ambiguous - if this is only option, just say "should be used directly"

You can just adopt this directly from Trello.

tjazerzen · 2025-10-13T11:48:01Z

mappings/external_domain_metadata_comments.plain

+  - text (display name: "Text", is required, type: rich text)
+  - author_id (display name: "Author ID", is required, type: reference)
+    - Field author_id refers to the record type "#record:users".
+    - Type of field author_id is an array with max_length 1, which can be used directly.


tjazerzen · 2025-10-13T11:48:16Z

mappings/external_domain_metadata_tasks.plain

+  - permalink (display name: "URL", is required, type: text)
+  - responsible_ids (display name: "Responsible IDs", is required, type: reference)
+    - Field responsible_ids refers to the record type "#record:users".
+    - Type of field responsible_ids is an array with max_length 1, which can be used as array value.


Same here ("can be used")

tjazerzen · 2025-10-13T11:52:49Z

test_data/data_extraction_continue_test.json

+              "external_system_id": "test-external_system_id",
+              "external_system_name": "Wrike",
+              "external_system_type": "ADaaS",
+              "import_slug": "trello-wrike-devrev",


Remove Trello reference

tjazerzen · 2025-10-13T11:53:33Z

test_data/data_extraction_continue_test.json

+              "key": "test-key",
+              "key_type": "",
+              "org_id": "test-org-id",
+              "org_name": "My FOlder"


I think "key" and "org_id" are not in the form we want them to be.

tjazerzen · 2025-10-13T11:55:15Z

test_data/external_domain_metadata_event_payload.json

+        "key": "test-connection-key",
+        "org_id": "test-org-id"


tjazerzen · 2025-10-13T11:58:04Z

devrev-wrike-snapin.plain

+- If "event_type" equals "EXTRACTION_DATA_START" or "EXTRACTION_DATA_CONTINUE" The Extraction Function should push the 'tasks' and 'users' data. To push the 'tasks' data, it should:
+  - If `TheExtractionStateObject["tasks"]["completed"]=false`:
+    - While Fetching The Fetched Tasks using pagination (The Tasks Iteration):
+      - When fetching The Fetched Tasks use the query param 'fields', where the value is an array of strings, which contains at least 'hasAttachments'.


I suggest you phrase which contains at least 'hasAttachments'. less ambiguously as we discussed, and render. I understand you got a conflict earlier. I think we should get to the root cause of the problem why a conflict exists, and then resolve it.

devrev-wrike-snapin.plain

patricijabrecko added 4 commits September 30, 2025 10:48

Updated spec

27f21cc

Some fixes of the specification

1406ab2

Remove authors IDs from IDM and EDM

2c4e081

Another minor update to spec

08465fc

tjazerzen suggested changes Oct 8, 2025

View reviewed changes

devrev-wrike-snapin.plain Show resolved Hide resolved

devrev-wrike-snapin.plain Show resolved Hide resolved

patricijabrecko added 2 commits October 9, 2025 09:35

Update Postman specification with rate limiting

9fdc7da

Spec fixes

4073bb6

patricijabrecko force-pushed the updated-spec branch from c5f3808 to 4073bb6 Compare October 9, 2025 09:03

Apply suggestions from code review

ebe9ffc

Co-authored-by: Tjaž Eržen <tjaz@codeplain.ai>

patricijabrecko force-pushed the updated-spec branch from 817f249 to 8f4d516 Compare October 9, 2025 10:09

patricijabrecko commented Oct 9, 2025

View reviewed changes

devrev-wrike-snapin.plain Outdated Show resolved Hide resolved

tjazerzen suggested changes Oct 9, 2025

View reviewed changes

More spec updates

7bf1bef

patricijabrecko force-pushed the updated-spec branch from 8f4d516 to 7bf1bef Compare October 10, 2025 12:57

tjazerzen suggested changes Oct 13, 2025

View reviewed changes

Update specification to include attachments and rate limiting #7

Are you sure you want to change the base?

Update specification to include attachments and rate limiting #7

Uh oh!

Conversation

patricijabrecko commented Oct 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tjazerzen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tjazerzen Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tjazerzen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tjazerzen Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tjazerzen Oct 13, 2025 •

edited

Loading

tjazerzen left a comment •

edited

Loading

tjazerzen Oct 13, 2025 •

edited

Loading