Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add bottom nav links #520

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Conversation

devrsi0n
Copy link
Owner

@devrsi0n devrsi0n commented Oct 29, 2022

Description

Also fixes the broken /docs/index, as it may be conflicted with Vercel route system.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

Checklist

  • Unit tests and integration tests passed
  • No reduction in test coverage
  • Documentation is up to date (if appropriate)
  • Related issues linked using fixes #number

@vercel
Copy link

vercel bot commented Oct 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chirpy ✅ Ready (Inspect) Visit Preview Oct 29, 2022 at 2:30PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2022

⚠️ No Changeset found

Latest commit: 2ac85ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Coverage report for ./apps/main

St.
Category Percentage Covered / Total
🔴 Statements
4.35% (-0.08% 🔻)
40/920
🔴 Branches
3.53% (-0.03% 🔻)
9/255
🔴 Functions
2.13% (-0.03% 🔻)
5/235
🔴 Lines
4.41% (-0.08% 🔻)
38/862

Test suite run success

2 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 2ac85ea

@relativeci
Copy link

relativeci bot commented Oct 29, 2022

Job #1073: Bundle Size — 1.99MiB (+0.07%).

b99a1a2(current) vs 89ee174 main#1065(baseline)

Metrics (3 changes)
                 Current
Job #1073
     Baseline
Job #1065
Initial JS 1.02MiB(+0.09%) 1.01MiB
Initial CSS 87.51KiB(+0.57%) 87.02KiB
Cache Invalidation 2.48% 2.94%
Chunks 50 50
Assets 59 59
Modules 1087 1087
Duplicate Modules 166 166
Duplicate Code 4.07% 4.07%
Packages 85 85
Duplicate Packages 1 1
Total size by type (2 changes)
                 Current
Job #1073
     Baseline
Job #1065
CSS 90.58KiB (+0.55%) 90.08KiB
Fonts 0B 0B
HTML 0B 0B
IMG 976B 976B
JS 1.89MiB (+0.05%) 1.89MiB
Media 0B 0B
Other 11.42KiB 11.42KiB

View job #1073 reportView main branch activity

@github-actions
Copy link
Contributor

Coverage report for ./packages/ui

St.
Category Percentage Covered / Total
🔴 Statements
51.88% (+0.03% 🔼)
2389/4605
🔴 Branches
26.29% (-0.06% 🔻)
457/1738
🔴 Functions
35.24% (+0.05% 🔼)
438/1243
🔴 Lines
51.92% (+0.03% 🔼)
2277/4386
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / link.tsx
85.71%
75.76% (-1.66% 🔻)
66.67% 85.19%

Test suite run success

50 tests passing in 32 suites.

Report generated by 🧪jest coverage report action from 2ac85ea

@cypress
Copy link

cypress bot commented Oct 29, 2022



Test summary

5 0 2 0Flakiness 0


Run details

Project chirpy
Status Passed
Commit 2ac85ea
Started Oct 29, 2022 2:32 PM
Ended Oct 29, 2022 2:34 PM
Duration 02:00 💡
OS Linux Ubuntu - 20.04
Browser Electron 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@devrsi0n devrsi0n merged commit b99a1a2 into main Oct 29, 2022
@devrsi0n devrsi0n deleted the feat/docs/add-bottom-nav-links branch October 29, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant