Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] refactor: move to tRPC #549

Merged
merged 34 commits into from
Dec 1, 2022
Merged

[BREAKING] refactor: move to tRPC #549

merged 34 commits into from
Dec 1, 2022

Conversation

devrsi0n
Copy link
Owner

@devrsi0n devrsi0n commented Nov 25, 2022 •
edited
Loading

Description

Related Issue

Closes #541

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

  • Unit tests and integration tests passed
  • No reduction in test coverage
  • Documentation is up to date (if appropriate)
  • Related issues linked using fixes #number

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 755a681

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 25, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chirpy ✅ Ready (Inspect) Visit Preview Dec 1, 2022 at 2:08PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022 •
edited
Loading

Coverage report for ./apps/main

St.❔
 Category Percentage Covered / Total
🔴 Statements
8.66% (+4.33% 🔼)
 40/462
🔴 Branches
10.23% (+6.75% 🔼)
 9/88
🔴 Functions
4.07% (+1.96% 🔼)
 5/123
🔴 Lines
9.16% (+4.77% 🔼)
 38/415
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🔴
... / [trpc].ts
 0% 100% 0% 0%

Test suite run success

2 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 755a681

@relativeci
Copy link

relativeci bot commented Nov 25, 2022 •
edited
Loading

Job #1181: Bundle Size — 2MiB (+1.03%).

a452cbe(current) vs 504186d main#1164(baseline)

Metrics (9 changes)
                 Current
Job #1181		      Baseline
Job #1164
Initial JS 1.03MiB(+1.99%) 1.01MiB
Initial CSS 85.6KiB 85.6KiB
Cache Invalidation 54.32% 0.77%
Chunks 50(+2.04%) 49
Assets 57(-3.39%) 59
Modules 1041(+3.48%) 1006
Duplicate Modules 179(+3.47%) 173
Duplicate Code 4.53%(+10.76%) 4.09%
Packages 90(+5.88%) 85
Duplicate Packages 0(-100%) 1
Total size by type (3 changes)
                 Current
Job #1181		      Baseline
Job #1164
CSS 88.66KiB 88.66KiB
Fonts 0B 0B
HTML 0B 0B
IMG 0B (-100%) 1.45KiB
JS 1.9MiB (+1.15%) 1.88MiB
Media 0B 0B
Other 11.52KiB (+1.27%) 11.37KiB

View job #1181 report View main branch activity

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022 •
edited
Loading

Coverage report for ./packages/ui

St.❔
 Category Percentage Covered / Total
🔴 Statements
52.75% (+0.04% 🔼)
 2341/4438
🔴 Branches
26.67% (+0.68% 🔼)
 431/1616
🔴 Functions
36.23% (+0.59% 🔼)
 455/1256
🔴 Lines
52.84% (-0.03% 🔻)
 2226/4213
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / trpc-client.ts
 100% 100% 100% 100%
🔴
... / use-register-device.ts
 23.08% 0% 0% 23.08%
🟢
... / index.tsx
 100% 100% 100% 100%
🟢
... / comment-forest.tsx
 82.35% 42.86% 75% 84.85%
🟢
... / use-comment-order-by.ts
 100% 100% 100% 100%
🔴
... / use-refetch-interval.ts
 16.67% 100% 0% 16.67%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟡 hooks/use-time.ts
73.33% (-13.33% 🔻)
40% (-20% 🔻)
66.67% (-22.22% 🔻)
76.92% (-15.38% 🔻)
🔴
... / use-create-a-comment.ts
20% (-3.53% 🔻)
 0% 0%
20% (-3.53% 🔻)
🔴
... / use-delete-a-comment.ts
20% (-5% 🔻)
 100% 0%
20% (-5% 🔻)
🔴
... / use-toggle-a-like-action.ts
15.15% (-3.37% 🔻)
 0% 0%
15.15% (-3.37% 🔻)
🟢
... / like-action.tsx
88% (-0.89% 🔻)
50% (-7.14% 🔻)
 100%
88% (-0.89% 🔻)
🔴
... / utilities.ts
8.11% (-0.51% 🔻)
 0% 0%
8.33% (-0.44% 🔻)
🟡
... / index.tsx
65.52% (-7.21% 🔻)
45.45% (+20.45% 🔼)
40% (-10% 🔻)
65.52% (-9.48% 🔻)
🟢
... / notification-hub.tsx
95.83% (-4.17% 🔻)
 90% 100%
95.65% (-4.35% 🔻)
🔴
... / use-force-update.ts
16.67% (-50% 🔻)
 100%
0% (-33.33% 🔻)
20% (-60% 🔻)
🔴
... / comment-widget-preview.tsx
 34.55%
18.18% (-1.82% 🔻)
 25% 35.85%
🟢
... / confirm-user-fields.tsx
80% (-0.49% 🔻)
82.14% (+3.57% 🔼)
 100%
82.05% (-0.45% 🔻)
🟡
... / project-card.tsx
77.55% (-5.78% 🔻)
50% (+8.33% 🔼)
 71.43%
77.55% (-5.78% 🔻)
🔴
... / redirecting.tsx
32% (-1.33% 🔻)
 0% 0%
32% (-1.33% 🔻)
🟡
... / index.tsx
60% (-6.67% 🔻)
 0% 0%
60% (-6.67% 🔻)

Test suite run success

50 tests passing in 32 suites.

Report generated by 🧪jest coverage report action from 755a681

@cypress
Copy link

cypress bot commented Nov 25, 2022 •
edited
Loading


Test summary

6 • 1 • 0 • 0 • Flakiness 0

Run details
Project chirpy
Status Failed
Commit 755a681
Started Dec 1, 2022 2:14 PM
Ended Dec 1, 2022 2:17 PM
Duration 03:11 💡
OS Linux Ubuntu - 22.04
Browser Chrome 107

View run in Cypress Dashboard ➡️

Failures

cypress/e2e/dashboard/project.spec.ts 1 Failed
1 Project > should active theme

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@devrsi0n devrsi0n changed the title [WIP] refactor: move to trpc [BREAKING] refactor: move to tRPC Nov 28, 2022
devrsi0n
devrsi0n commented Nov 28, 2022
View reviewed changes
apps/main/src/pages/play.tsx Outdated Show resolved Hide resolved
packages/emails/typings/node.d.ts Outdated Show resolved Hide resolved
packages/trpc/src/index.ts Outdated Show resolved Hide resolved
packages/trpc/src/mutation-event/comment-handler.ts Show resolved Hide resolved
packages/trpc/src/mutation-event/comment-handler.ts Show resolved Hide resolved
packages/ui/src/blocks/comment-forest/comment-forest.tsx Outdated Show resolved Hide resolved
packages/ui/src/blocks/comment-forest/use-comment-order-by.ts Outdated Show resolved Hide resolved
packages/ui/src/blocks/comment-timeline/comment-timeline.tsx Show resolved Hide resolved
packages/ui/src/blocks/notification-hub/notification-hub.tsx Outdated Show resolved Hide resolved
packages/ui/src/contexts/notification-context/use-register-device.ts Show resolved Hide resolved
@devrsi0n devrsi0n merged commit a452cbe into main Dec 1, 2022
@devrsi0n devrsi0n deleted the refactor/trpc branch December 1, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to trpc
1 participant
@devrsi0n