fix:provisionConfig support defaultTarget and deploy cn-shanghai-fina… #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsonghuster
reviewed
Dec 12, 2024
src/resources/fc/index.ts
Outdated
| @@ -314,7 +314,9 @@ export default class FC extends FC_Client { | |||
| if (this.customEndpoint) { | |||
| ossEndpoint = `oss-${this.region}.aliyuncs.com`; | |||
| } | |||
|
|
|||
| if (this.region === 'cn-shanghai-finance-1'){ | |||
There was a problem hiding this comment.
这个也加上 如果 process.env.FC_REGION === this.region ， 走内网吧， 我记得这个也是有内网的吧
rsonghuster
reviewed
Dec 12, 2024
src/subCommands/provision/index.ts
Outdated
| @@ -105,14 +109,15 @@ export default class Provision { | |||
| throw new Error('Qualifier not specified, please specify --qualifier'); | |||
| } | |||
|
|
|||
| if (!_.isNumber(this.target)) { | |||
| if (!_.isNumber(this.defaultTarget || this.target)) { | |||
| throw new Error( | |||
| `Target must be a number, got ${this.target}. Please specify a number through --target <number>`, | |||
There was a problem hiding this comment.
这个报错， 是不是提示 defaultTarget 和 target
rsonghuster
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:provisionConfig support defaultTarget and deploy cn-shanghai-finance-1