Migrate Degree Wizard to React Query #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: imagine-hussain <imagine-hussain@users.noreply.github.com>
Peedee2002
reviewed
Jul 9, 2023
|
Almost there! Just a few small fixes with input validation in the new API route to handle now, and a good review from @leonardo-fan and @imagine-hussain. |
lhvy
changed the title
|
More changes made:
Future implications (Out of Scope)
|
imagine-hussain
approved these changes
Jul 12, 2023
|
Tests will fail due to changes - tests are out of date - aactual thing builds. |
imagine-hussain
merged commit cc05d77
into
CIRCLES-331/user-data-to-backend
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently errors in the degree wizard merged into CIRCLES-331 that makes testing other branches somewhat difficult. This PR is a
quickattempt to fix the ones stopping the front page from even loading.The React Query migration for the Degree Wizard is almost entirely covered by this PR. This should also cover all the changes in #1060 at the same time.