Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(be): Fix backend tests #1164

Merged
merged 8 commits into from
Jul 26, 2024
Merged

fix(be): Fix backend tests #1164

merged 8 commits into from
Jul 26, 2024

Conversation

lhvy
Copy link
Contributor

@lhvy lhvy commented Jul 17, 2024

  • Fixes tests for the backend post auth changes

Huge thanks @Peedee2002 for finishing the remaining tests

@lhvy lhvy added 📝 tests 🧪 Request for more tests 🫣 331 🤫 Is only in scope within the current 331 branch labels Jul 17, 2024
@lhvy lhvy self-assigned this Jul 17, 2024
@lhvy lhvy requested a review from a team as a code owner July 17, 2024 12:12
@github-actions GitHub Actions
Copy link

Test Results

156 tests  ±0   121 ✅ +41   43s ⏱️ +4s
 13 suites ±0     2 💤 ± 0 
  2 files   ±0    33 ❌  - 41 

For more details on these failures, see this check.

Results for commit ee71f43. ± Comparison against base commit f142dab.

ollibowers
ollibowers requested changes Jul 23, 2024
View reviewed changes
backend/server/routers/courses.py Outdated Show resolved Hide resolved
backend/server/tests/user/utility.py Outdated Show resolved Hide resolved
backend/server/tests/courses/test_search_course.py Outdated Show resolved Hide resolved
backend/server/tests/courses/test_search_course.py Outdated Show resolved Hide resolved
backend/algorithms/objects/user.py Show resolved Hide resolved
ollibowers
ollibowers approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@ollibowers ollibowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ollibowers ollibowers merged commit fe22a61 into 331-staging Jul 26, 2024
8 checks passed
@ollibowers ollibowers deleted the fix/be/fix-tests branch July 26, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peedee2002 Peedee2002 Peedee2002 left review comments

@ollibowers ollibowers ollibowers approved these changes

Assignees

@lhvy lhvy

Labels
📝 tests 🧪 Request for more tests 🫣 331 🤫 Is only in scope within the current 331 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhvy @Peedee2002 @ollibowers