fix(api): refactor utility functions to detangle dependencies and reduce coupling #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated get_course_details in utility.py
…n terms_offered route function
…reeWizard to not rely on route functions
…t all dependencies from program routers
…y into it and rename
justjo3l
pushed a commit
that referenced
this pull request
Sep 20, 2024
…uce coupling (#1189) * refactor(utility): removed reliance on get_course route function, created get_course_details in utility.py * refactor(utility): created term offering helpers to remove reliance on terms_offered route function * refactor(utility): created specialisation getter, refactored setupDegreeWizard to not rely on route functions * refactor(utility): created get_program_structure utility and moved out all dependencies from program routers * refactor(utility): moved out regex_search to utility.py * wip: move out user helpers into their own file * refactor(utility): moved out logic for and some graph helpers into utility.py * fix: switched up setup_degree_wizard so we can get a bit better type inference * fix: new line at end of user.py * fix: remove unused CODE_MAPPING cache constant * refactor: routers folder structure - move middleware.py into sessions utility folder * refactor: routers folder - rename auth_utility folder, move utility.py into it and rename * refactor: routers folder - move manual_fixes into utility folder * fix: remove my todo list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goals:
PlannerDatathat is currently in progress of removal)main changes:
server/routers/auth_utility/ -> server/routers/utility/server/routers/utility.py -> server/routers/utility/common.py(advice appreciated on this new file name)utility/common.py