-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create button component #24
Conversation
UIX-56 Code up buttons
Finally a coding ticket xD. Essentially, code up the button component into the ui-components repo here https://github.com/csesoc/ui-components. Some styles should have been provided in main somewhere but all you have to do is build upon that to include buttons (and all it's variants). If possible, could you abstract some things like types and styles that currently exists in the code to it's own folder/file (ie. |
From the screen recording, the icon in the 'button with icon' looks like it's the wrong colour. Also, make sure to add this to the CHANGELOG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Resolve the comment then merge :)
very epic buttons !!!!! |
button and its variants working :D
(dark mode looks scuffed on ghost and text buttons in the gif but it's just because the background's transparent)