Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create button component #24

Merged
merged 8 commits into from
Oct 7, 2023
Merged

feat: create button component #24

merged 8 commits into from
Oct 7, 2023

Conversation

aquivere
Copy link
Contributor

@aquivere aquivere commented Jul 4, 2023

button and its variants working :D

(dark mode looks scuffed on ghost and text buttons in the gif but it's just because the background's transparent)
Recording 2023-07-04 at 17 05 57

@aquivere aquivere requested a review from Darianlmj July 4, 2023 07:06
@linear
Copy link

linear bot commented Jul 4, 2023

UIX-56 Code up buttons

Finally a coding ticket xD. Essentially, code up the button component into the ui-components repo here https://github.com/csesoc/ui-components. Some styles should have been provided in main somewhere but all you have to do is build upon that to include buttons (and all it's variants).

If possible, could you abstract some things like types and styles that currently exists in the code to it's own folder/file (ie. types/button.ts)

@Darianlmj
Copy link
Contributor

From the screen recording, the icon in the 'button with icon' looks like it's the wrong colour. Also, make sure to add this to the CHANGELOG

Copy link
Contributor

@Darianlmj Darianlmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Resolve the comment then merge :)

@Darianlmj Darianlmj changed the title create button component feat: create button component Oct 7, 2023
@aquivere aquivere merged commit df31b33 into main Oct 7, 2023
@aquivere aquivere deleted the UIX-56/button branch October 7, 2023 08:51
@floyrin
Copy link

floyrin commented Oct 16, 2023

very epic buttons !!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants