Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Modal Component #34

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Modal Component #34

wants to merge 6 commits into from

Conversation

sharkbaitchomp
Copy link

Implemented modal component.

MerryRosalie
MerryRosalie reviewed Jun 3, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
MerryRosalie
MerryRosalie requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@MerryRosalie MerryRosalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Junya, looks good to me! 🥺 Just one thing: you should definitely have the modal have a 'position: fixed' in the centre of the screen. Also, add a transparent dark background behind the modal while it is open. Optionally, you can also make it such that when the user clicks outside the modal(or the dark background), it also closes the modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerryRosalie MerryRosalie MerryRosalie requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharkbaitchomp @MerryRosalie