Improve init and dev #656
Closed
Improve init and dev #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasGentele
added
priority/longterm
area/init
FabianKramm
requested changes
Aug 30, 2019
FabianKramm
requested changes
Aug 30, 2019
FabianKramm
requested changes
Aug 30, 2019
added 8 commits
August 30, 2019 05:59
added 9 commits
August 31, 2019 14:09
Improve readme
FabianKramm
requested changes
Sep 2, 2019
added 19 commits
September 2, 2019 08:51
|
closing this in favor of #662 662 |
LukasGentele
pushed a commit
that referenced
this pull request
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What is this pull request for? Which issues does it resolve? (use
resolves #<issue_number>if possible)This PR changes the behavior of init (see below) and adds a the
--interactive / -iflag todevspace dev.Also resolves #655
Does this pull request has user-facing changes? (e.g. config changes, new/modified commands, new/modified flags)
Yes:
initwarns when application listens on a system port and asks for forwarding portinitnow writes a different config which by default disables the terminal and does not override the entrypoint anymoreDoes this pull request add new dependencies?
No
What else do we need to know?
Due to a cobra issue (spf13/cobra#866), the --interactive flag must be used as
-i/--interactive=valueinstead of-i/--interactive value(or alternatively without value at all).