Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silver Surfer #14

Closed
Kristories opened this issue Jul 16, 2022 · 5 comments
Closed

Silver Surfer #14

Kristories opened this issue Jul 16, 2022 · 5 comments
Assignees
@Kristories

Comments

@Kristories
Copy link
Member

Kristories commented Jul 16, 2022 •
edited
Loading

Ref : #11 #12 #13 #15
@Kristories Kristories self-assigned this Jul 16, 2022
@Kreshnik
Copy link

Pretty please fix this issue 😇

@Synchro
Copy link

Synchro commented Jul 25, 2022

Some further detail that might help. The QR renders to this, which is an empty tag. There are no JS errors logged:

<detail-qrcode index="3" resource-name="products" resource-id="66118" resource="[object Object]" field="[object Object]"></detail-qrcode>

@Synchro
Copy link

Synchro commented Aug 12, 2022

Is there anything we can do to help get this fixed? Do you know what the problem is?

lenada added a commit to lenada/nova-qrcode-field that referenced this issue Aug 21, 2022
@lenada
Fix for Nova 4.12.14
9658d44 
fixes devtical#14
I only figured this out by trial and error; some naming convention within nova must have changed 🤷
The dist assets probably need recompilation
@lenada lenada mentioned this issue Aug 21, 2022
Closed
@Kristories
Copy link
Member Author

Please use v2.0.0 using composer require devtical/nova-qrcode-field.

Thank you for being so patient. We try to do our best.

This was referenced Sep 21, 2022
Closed
Closed
@Synchro
Copy link

Synchro commented Sep 21, 2022

Hooray! Thank you!

@Kristories Kristories mentioned this issue Sep 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kristories Kristories

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for Nova 4.12.14 (Silver Surfer) lenada/nova-qrcode-field
3 participants
@Synchro @Kristories @Kreshnik