refrain from checkin autoscalingCheckBeforeTrigger for virt clus (#5696)

devtron-labs · Aug 20, 2024 · 4f04d6b · 4f04d6b
1 parent 779e913
commit 4f04d6b
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/pkg/deployment/manifest/ManifestCreationService.go b/pkg/deployment/manifest/ManifestCreationService.go
@@ -275,10 +275,12 @@ func (impl *ManifestCreationServiceImpl) GetValuesOverrideForTrigger(overrideReq
 			// error is not returned as it's not blocking for deployment process
 			// blocking deployments based on this use case can vary for user to user
 		}
-		mergedValues, err = impl.autoscalingCheckBeforeTrigger(newCtx, appName, envOverride.Namespace, mergedValues, overrideRequest)
-		if err != nil {
-			impl.logger.Errorw("error in autoscaling check before trigger", "pipelineId", overrideRequest.PipelineId, "err", err)
-			return valuesOverrideResponse, err
+		if !envOverride.Environment.IsVirtualEnvironment {
+			mergedValues, err = impl.autoscalingCheckBeforeTrigger(newCtx, appName, envOverride.Namespace, mergedValues, overrideRequest)
+			if err != nil {
+				impl.logger.Errorw("error in autoscaling check before trigger", "pipelineId", overrideRequest.PipelineId, "err", err)
+				return valuesOverrideResponse, err
+			}
 		}
 		// handle image pull secret if access given
 		mergedValues, err = impl.dockerRegistryIpsConfigService.HandleImagePullSecretOnApplicationDeployment(newCtx, envOverride.Environment, artifact, pipeline.CiPipelineId, mergedValues)