Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Docker pull env driven #5767

Merged
merged 8 commits into from
Aug 30, 2024
Merged

feat: Docker pull env driven #5767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0e67bc3
useDockerApiToGetDigest menv driven flag to control pulling image eit…
prakash100198 Aug 27, 2024
c3e9898
Merge branch 'main' into docker-pull-env-driven
prakash100198 Aug 27, 2024
c216904
Merge branch 'main' into docker-pull-env-driven
prakash100198 Aug 30, 2024
c88eca8
UseAppDockerConfigForPrivateRegistries in workflow request
prakash100198 Aug 30, 2024
dffa767
revert
prakash100198 Aug 30, 2024
e3a84ad
revert
prakash100198 Aug 30, 2024
cc2e1c9
Merge branch 'main' into docker-pull-env-driven
prakash100198 Aug 30, 2024
cf02784
Merge branch 'main' into docker-pull-env-driven
prakash100198 Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions env_gen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@
| USE_CASBIN_V2 | false | |
| USE_CUSTOM_HTTP_TRANSPORT | false | |
| USE_DEPLOYMENT_CONFIG_DATA | false | |
| USE_DOCKER_API_TO_GET_DIGEST | false | |
| USE_EXTERNAL_NODE | false | |
| USE_GIT_CLI | false | |
| USE_IMAGE_TAG_FROM_GIT_PROVIDER_FOR_TAG_BASED_BUILD | false | |
Expand Down
1 change: 1 addition & 0 deletions pkg/pipeline/CiService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,7 @@ func (impl *CiServiceImpl) buildWfRequestForCiPipeline(pipeline *pipelineConfig.
PluginArtifactStage: pluginArtifactStage,
ImageScanMaxRetries: impl.config.ImageScanMaxRetries,
ImageScanRetryDelay: impl.config.ImageScanRetryDelay,
UseDockerApiToGetDigest: impl.config.UseDockerApiToGetDigest,
}
if pipeline.App.AppType == helper.Job {
workflowRequest.AppName = pipeline.App.DisplayName
Expand Down
1 change: 1 addition & 0 deletions pkg/pipeline/types/CiCdConfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ type CiCdConfig struct {
ExtBlobStorageSecretName string `env:"EXTERNAL_BLOB_STORAGE_SECRET_NAME" envDefault:"blob-storage-secret"`
UseArtifactListingQueryV2 bool `env:"USE_ARTIFACT_LISTING_QUERY_V2" envDefault:"true"`
UseImageTagFromGitProviderForTagBasedBuild bool `env:"USE_IMAGE_TAG_FROM_GIT_PROVIDER_FOR_TAG_BASED_BUILD" envDefault:"false"` // this is being done for https://github.com/devtron-labs/devtron/issues/4263
UseDockerApiToGetDigest bool `env:"USE_DOCKER_API_TO_GET_DIGEST" envDefault:"false"`
}

type CiConfig struct {
Expand Down
1 change: 1 addition & 0 deletions pkg/pipeline/types/Workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ type WorkflowRequest struct {
Scope resourceQualifiers.Scope
BuildxCacheModeMin bool `json:"buildxCacheModeMin"`
AsyncBuildxCacheExport bool `json:"asyncBuildxCacheExport"`
UseDockerApiToGetDigest bool `json:"useDockerApiToGetDigest"`
}

func (workflowRequest *WorkflowRequest) updateExternalRunMetadata() {
Expand Down
Loading