Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: oss ent triggerService changes #6189

Merged
merged 15 commits into from
Dec 19, 2024
Merged

chore: oss ent triggerService changes #6189

merged 15 commits into from
Dec 19, 2024

Conversation

kartik-579
Copy link
Member

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented Dec 17, 2024

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
141558 Triggered Generic High Entropy Secret 8c324c5 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/env-values.yaml View secret
2763127 Triggered Generic High Entropy Secret 8c324c5 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret 8c324c5 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml View secret
9257608 Triggered Base64 AWS keys 8c324c5 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/test-values.json View secret
141558 Triggered Generic High Entropy Secret 8c324c5 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml View secret
10220829 Triggered Generic High Entropy Secret 8fb2117 charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret 8fb2117 charts/devtron/devtron-bom.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

The migration files have successfully passed the criteria!!

Copy link

The migration files have successfully passed the criteria!!

@kartik-579 kartik-579 merged commit 7fbf67a into develop Dec 19, 2024
6 checks passed
@kartik-579 kartik-579 deleted the oss-ent-if-impl-1 branch December 19, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants