Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code from test-construct 1.2.0 release #2

Merged
merged 1 commit into from
Nov 27, 2013

Conversation

bf4
Copy link

@bf4 bf4 commented Nov 25, 2013

More or less what I did

git clone devver/construct
gem fetch test-contstruct
gem unpack test-construct
cd construct
cp -Rp ../test-contruct-1.2.0.gem/* .
git checkout -b test-construct
git commit -am 'Update code from rubygem'

@avdi
Copy link
Collaborator

avdi commented Nov 25, 2013

This seems like a no-brainer -- @bhb, @danmayer any issues merging this?

@bf4
Copy link
Author

bf4 commented Nov 25, 2013

BTW, if you intend to re-maintain the repo here, please enable issues!

@danmayer
Copy link
Collaborator

No issues from me I still like and use construct as well. I am away from a
computer but could merge and turn on issues tomorrow. Do we want to
maintain here or we could move it under the metric_fu org
On Nov 25, 2013 4:11 PM, "Benjamin Fleischer" notifications@github.com
wrote:

BTW, if you intend to re-maintain the repo here, please enable issues!


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-29252366
.

@bhb
Copy link
Collaborator

bhb commented Nov 26, 2013

I'm confused as to how the published gem is out of sync, but whatever. I'm happy to revive this, but I'll do it back under my account. I don't really want to keeping things in the @devver account. @avdi @danmayer Cool?

@avdi
Copy link
Collaborator

avdi commented Nov 26, 2013

Fine by me!

On Mon, Nov 25, 2013 at 10:51 PM, Ben Brinckerhoff <notifications@github.com

wrote:

I'm confused as to how the published gem is out of sync, but whatever. I'm
happy to revive this, but I'll do it back under my account. I don't really
want to keeping things in the @devver https://github.com/devveraccount.
@avdi https://github.com/avdi @danmayer https://github.com/danmayerCool?


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-29265693
.

Avdi Grimm
http://avdi.org

I only check email twice a day. to reach me sooner, go to
http://awayfind.com/avdi

@bf4
Copy link
Author

bf4 commented Nov 26, 2013

So, I'll add you all at metricfu/construct and whoever controls the devver rubygems account (I think @danmayer) should add some more owners :)

@bf4
Copy link
Author

bf4 commented Nov 26, 2013

Oops, @bhb totally misread that. Back at your account :)

@danmayer
Copy link
Collaborator

Bens account works for me. Agree dont want anything under the devver
account. I am also cool with it under metric_fu, either way.
On Nov 25, 2013 9:36 PM, "Benjamin Fleischer" notifications@github.com
wrote:

Oops, @bhb https://github.com/bhb totally misread that. Back at your
account :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-29266995
.

@danmayer
Copy link
Collaborator

So wish we could have just published it as contract on ruby gems. I guess when we published it we never updated the main repo. Thanks for fixing the mismatch up @bf4

@bf4
Copy link
Author

bf4 commented Nov 26, 2013

Well, whatever you guys decide, Make sure you update the repo to reference the new location, as e.g. @davetron5000's book points here

@bhb bhb merged commit d550734 into devver:master Nov 27, 2013
@bhb
Copy link
Collaborator

bhb commented Nov 27, 2013

@bf4 I'm looking into it, but my current plan is to switch to a new gem name as the spiritual successor and just redirect everything there.

@avdi
Copy link
Collaborator

avdi commented Nov 27, 2013

Why the new name?

On Tue, Nov 26, 2013 at 9:37 PM, Ben Brinckerhoff
notifications@github.comwrote:

@bf4 https://github.com/bf4 I'm looking into it, but my current plan is
to switch to a new gem name as the spiritual successor and just redirect
everything there.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-29355825
.

Avdi Grimm
http://avdi.org

I only check email twice a day. to reach me sooner, go to
http://awayfind.com/avdi

@bhb
Copy link
Collaborator

bhb commented Nov 27, 2013

@avdi I really like the name. Unfortunately, "construct" is already a different gem. The current gem name "test-construct" violates gem naming best practices. Not only does the gem name not match the actual classes, it also misleadingly implies that the classes will be named Test::Construct (which itself implies some connection to Test::Unit). Gems that make me guess how to require and/or call them are a pet peeve of mine.

In light of that, my current plan is to just make a new gem named "test_construct". The module name will be TestConstruct. It's not as nice as the old name, but then again, the old name was never fully the "real" name anyway.

I'm interested in your thoughts on this.

@avdi
Copy link
Collaborator

avdi commented Nov 27, 2013

OK, that makes sense. It's probably better than my plan of abducting Kyle
Kingsbury and showing him Miley Cyrus until he agrees to give us the
"construct" gem name.

On Tue, Nov 26, 2013 at 11:54 PM, Ben Brinckerhoff <notifications@github.com

wrote:

@avdi https://github.com/avdi I really like the name. Unfortunately,
"construct" is already a different gemhttp://rubygems.org/search?utf8=%E2%9C%93&query=construct.
The current gem name "test-construct" violates gem naming best practiceshttp://guides.rubygems.org/name-your-gem/.
Not only does the gem name not match the actual classes, it also
misleadingly implies that the classes will be named Test::Construct(which itself implies some connection to
Test::Unit). Gems that make me guess how to require and/or call them are
a pet peeve of mine.

In light of that, my current plan is to just make a new gem named
"test_construct". The module name will be TestConstruct. It's not as nice
as the old name, but then again, the old name was never fully the "real"
name anyway.

I'm interested in your thoughts on this.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-29360216
.

Avdi Grimm
http://avdi.org

I only check email twice a day. to reach me sooner, go to
http://awayfind.com/avdi

@bhb
Copy link
Collaborator

bhb commented Nov 27, 2013

My plan is simpler, but not necessarily better.

@avdi
Copy link
Collaborator

avdi commented Nov 27, 2013

That was supposed to read "Miley Cyrus videos". Let the record show that I
am not in possession of a Miley Cyrus.

@bf4
Copy link
Author

bf4 commented Nov 27, 2013

Now if only there were a miley cyrus emoji...

@bhb
Copy link
Collaborator

bhb commented Dec 4, 2013

@bf4 @davetron5000 OK, the new repo is here, with Issues enabled. I've added a deprecation warning to the README.

@bf4
Copy link
Author

bf4 commented Dec 4, 2013

Great!

@bf4
Copy link
Author

bf4 commented Dec 4, 2013

@bhb you can also update the repo title/link with someone like what I did when roodi was revived

@bhb
Copy link
Collaborator

bhb commented Dec 5, 2013

@bf4 Yeah, that would be a good idea, except none of us can remember the password for the "devver" account. Fail.

@bhb
Copy link
Collaborator

bhb commented Dec 5, 2013

Oh snap, just figured it out. Done and done.

@bf4
Copy link
Author

bf4 commented Dec 5, 2013

@bhb Now you just need to release a 'please update' gem :)

I released a 3.0.0 for metric_fu-roodi that tells you to upgrade. Try it ;)

@bhb
Copy link
Collaborator

bhb commented Dec 16, 2013

Good idea. Done!

@bf4 bf4 deleted the test-construct branch December 16, 2013 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants