-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERROR in BusyModule is not an NgModule #33
Comments
same issue |
2 similar comments
same issue |
same issue |
I have the same problem. |
same issue |
Same |
same, tested with |
Has anyone fixed this bug? |
Same error for me with: |
same |
Any idea how to fix this? |
same issue. any idea how to fix? |
same! any idea? |
the same issue. any idea when it will be fixed? |
Same error for me with: |
Same issues |
Same issue here after upgrading to @angular/cli@latest on Windows 10- is there a fix in the works? @angular/cli: 1.0.0-beta.32.3 |
+1 |
A possible workaround, until it is patched, is to comment out Then ng build -w or whatever you prefer. Once it is built remove the comments. It just throws a fit during the build but it still works fine. |
same issue |
+1 |
same issue |
yep! same issue... |
same here |
Same here |
Changing the order in app.module.ts from
to
worked for me |
@devyumao , you can take a look at this issue: angular/angular-cli#3426 (comment) maybe it will be able to help. Do you plan to keep the library updated or it is abandoned currently? |
I have added the metadata.json files. It works. Please use this until the official module is fixed. https://github.com/dinusuresh/angular2-busy package.json: NOTE |
Thank you @dinusuresh ! The solution you provided works on my side too! 👍 Why don't you consider to issue a pull request to https://github.com/devyumao/angular2-busy ? I bet this would help @devyumao deal with this issue faster. |
Yay! Works great! Thanks, Dinesh!
From: Dinesh [mailto:notifications@github.com]
Sent: Friday, March 10, 2017 5:43 AM
To: devyumao/angular2-busy
Cc: Hatfield, R. Scott; Comment
Subject: Re: [devyumao/angular2-busy] ERROR in BusyModule is not an NgModule (#33)
I have fixed this error. Please use this until the official module is fixed.
https://github.com/dinusuresh/angular2-busy
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#33 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABDSfemQtnuFzG9iunR8soclrhBApxCxks5rkSk4gaJpZM4L02hA>.
|
Thanks a lot @dinusuresh 👍 your fix also worked for me. |
Thanks @dinusuresh its works for me too!!! I updated "ts-metadata-helper" and "angular2-dynamic-component" packages in my projetc too... |
Glad I could help 😄 @superKalo I have created a pull request but considering the author is not active ATM I do not know if and when it will be accepted. |
Can anyone please explain me how to solve this problem? I didn't understand what I have to change :) |
@M4NC1O Sure. If you are looking to just get it working, then In you package.json file make sure the angular2-busy dependency line is like this: remove node_modules folder if you have it
|
It works! |
Thank you ! |
It works well..thanks |
When I build --aot I lose the spinner and the label "Loading..".. does anyone have the same issue? |
@dinusuresh: started getting error "DynamicComponentModule is not an NgModule".. |
@Niraj-Sharma Please can you post your package.json and output of It is working good on my end, the only warning is the rxjs version 5.0.2 which is used by angular2-dynamic-component @M4NC1O I will look into it and let you know. |
Now the module has been fixed. |
@Niraj-Sharma Now the module does not rely on angular2-dynamic-component any more. Please update to the latest version. |
@devyumao Thank you! Glad to have you back 😄 |
Hello, I followed solution by dinusuresh, but it's not working. Please provide solution. Currently, I am using loader with observables but problem is loader gets activated for any request to Server it's just because of service we are using. Please provide solution. |
I get this error when I import BusyModule. Or this library only works on Angular 2.0.0?
"dependencies": {
"@angular/common": "^2.3.1",
"@angular/compiler": "^2.3.1",
"@angular/core": "^2.3.1",
"@angular/forms": "^2.3.1",
"@angular/http": "^2.3.1",
"@angular/platform-browser": "^2.3.1",
"@angular/platform-browser-dynamic": "^2.3.1",
"@angular/router": "^3.3.1",
"angular2-busy": "^1.0.2",
"angularfire2": "^2.0.0-beta.7",
"bootstrap": "^3.3.7",
"core-js": "^2.4.1",
"firebase": "^3.6.8",
"ng2-bootstrap": "^1.3.2",
"rxjs": "^5.0.1",
"ts-helpers": "^1.1.1",
"zone.js": "^0.7.2"
},
"devDependencies": {
"@angular/compiler-cli": "^2.3.1",
"@types/jasmine": "2.5.38",
"@types/node": "^6.0.42",
"angular-cli": "1.0.0-beta.26",
"codelyzer": "~2.0.0-beta.1",
"jasmine-core": "2.5.2",
"jasmine-spec-reporter": "2.5.0",
"karma": "1.2.0",
"karma-chrome-launcher": "^2.0.0",
"karma-cli": "^1.0.1",
"karma-jasmine": "^1.0.2",
"karma-remap-istanbul": "^0.2.1",
"protractor": "~4.0.13",
"ts-node": "1.2.1",
"tslint": "^4.3.0",
"typescript": "~2.0.3"
}
The text was updated successfully, but these errors were encountered: