Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR in BusyModule is not an NgModule #33

Closed
calvingferrando18 opened this issue Feb 2, 2017 · 47 comments
Closed

ERROR in BusyModule is not an NgModule #33

calvingferrando18 opened this issue Feb 2, 2017 · 47 comments

Comments

@calvingferrando18
Copy link

I get this error when I import BusyModule. Or this library only works on Angular 2.0.0?

"dependencies": {
"@angular/common": "^2.3.1",
"@angular/compiler": "^2.3.1",
"@angular/core": "^2.3.1",
"@angular/forms": "^2.3.1",
"@angular/http": "^2.3.1",
"@angular/platform-browser": "^2.3.1",
"@angular/platform-browser-dynamic": "^2.3.1",
"@angular/router": "^3.3.1",
"angular2-busy": "^1.0.2",
"angularfire2": "^2.0.0-beta.7",
"bootstrap": "^3.3.7",
"core-js": "^2.4.1",
"firebase": "^3.6.8",
"ng2-bootstrap": "^1.3.2",
"rxjs": "^5.0.1",
"ts-helpers": "^1.1.1",
"zone.js": "^0.7.2"
},
"devDependencies": {
"@angular/compiler-cli": "^2.3.1",
"@types/jasmine": "2.5.38",
"@types/node": "^6.0.42",
"angular-cli": "1.0.0-beta.26",
"codelyzer": "~2.0.0-beta.1",
"jasmine-core": "2.5.2",
"jasmine-spec-reporter": "2.5.0",
"karma": "1.2.0",
"karma-chrome-launcher": "^2.0.0",
"karma-cli": "^1.0.1",
"karma-jasmine": "^1.0.2",
"karma-remap-istanbul": "^0.2.1",
"protractor": "~4.0.13",
"ts-node": "1.2.1",
"tslint": "^4.3.0",
"typescript": "~2.0.3"
}

@kthomas80
Copy link

same issue

2 similar comments
@danilodevhub
Copy link

same issue

@qcnguyen
Copy link

qcnguyen commented Feb 9, 2017

same issue

@oslanier
Copy link

oslanier commented Feb 9, 2017

I have the same problem.

@flexkiran
Copy link

same issue

@Trenrod
Copy link

Trenrod commented Feb 10, 2017

Same

@SimoneMSR
Copy link

SimoneMSR commented Feb 10, 2017

same, tested with
"typescript": "~2.0.3"

@marciomsm
Copy link

Has anyone fixed this bug?

@gepisolo
Copy link

Same error for me with:
"@angular/compiler-cli": "^2.3.1",
"angular-cli": "1.0.0-beta.24",
"typescript": "~2.0.3"

@bashoogzaad
Copy link

same

@bashoogzaad
Copy link

Any idea how to fix this?

@michalzfania
Copy link

same issue. any idea how to fix?

@emidel
Copy link

emidel commented Feb 19, 2017

same! any idea?

@ghost
Copy link

ghost commented Feb 20, 2017

the same issue. any idea when it will be fixed?

@trueflywood
Copy link

Same error for me with:
"@angular/compiler-cli": "^2.4.8",
"angular-cli": "1.0.0-beta.32.3",

@nolafs
Copy link

nolafs commented Feb 20, 2017

Same issues
"@angular/compiler-cli": "^2.3.1",
"angular-cli": "1.0.0-beta.28.3",

@tmwnni
Copy link

tmwnni commented Feb 21, 2017

Same issue here after upgrading to @angular/cli@latest on Windows 10- is there a fix in the works?

@angular/cli: 1.0.0-beta.32.3
node: 7.3.0
os: win32 x64
@angular/cli: 1.0.0-beta.32.3
@angular/common: 2.4.8
@angular/compiler: 2.4.8
@angular/compiler-cli: 2.4.8
@angular/core: 2.4.8
@angular/forms: 2.4.8
@angular/http: 2.4.8
@angular/platform-browser: 2.4.8
@angular/platform-browser-dynamic: 2.4.8
@angular/router: 3.4.8

@SerhiiTsybulskyi
Copy link

+1

@justicewebtech
Copy link

A possible workaround, until it is patched, is to comment out
imports: [ ...
//,BusyModule
...]

Then ng build -w or whatever you prefer. Once it is built remove the comments. It just throws a fit during the build but it still works fine.

@s-inshiy
Copy link

s-inshiy commented Feb 25, 2017

same issue

@tim-hoffmann
Copy link

+1

@stanciupaul
Copy link

same issue

@GuiFSimoes
Copy link

yep! same issue...

@rshatf
Copy link

rshatf commented Mar 2, 2017

same here

@chintharr
Copy link

Same here

@smainz
Copy link

smainz commented Mar 5, 2017

Changing the order in app.module.ts from

@NgModule({
  imports: [
    ...
    BusyModule,

  ],
  declarations: [
   ...

  ],

  ...
}

to

@NgModule({
  declarations: [
   ...

  ],
  imports: [
    ...
    BusyModule,

  ],
  ...
}

worked for me

@superKalo
Copy link

@devyumao , you can take a look at this issue: angular/angular-cli#3426 (comment) maybe it will be able to help.

Do you plan to keep the library updated or it is abandoned currently?

@dinusuresh
Copy link

dinusuresh commented Mar 10, 2017

I have added the metadata.json files. It works. Please use this until the official module is fixed.

https://github.com/dinusuresh/angular2-busy

package.json:
"angular2-busy": "https://github.com/dinusuresh/angular2-busy.git"

NOTE
I have updated packages in package.json to use latest stable version as per my project needs. If you need them to match yours consider forking and change versions to meet your project needs.

@superKalo
Copy link

Thank you @dinusuresh ! The solution you provided works on my side too! 👍

Why don't you consider to issue a pull request to https://github.com/devyumao/angular2-busy ? I bet this would help @devyumao deal with this issue faster.

@rshatf
Copy link

rshatf commented Mar 10, 2017 via email

@bgaillard
Copy link

bgaillard commented Mar 10, 2017

Thanks a lot @dinusuresh 👍 your fix also worked for me.

@GuiFSimoes
Copy link

Thanks @dinusuresh its works for me too!!!

I updated "ts-metadata-helper" and "angular2-dynamic-component" packages in my projetc too...

@dinusuresh
Copy link

Glad I could help 😄

@superKalo I have created a pull request but considering the author is not active ATM I do not know if and when it will be accepted.

@M4NC1O
Copy link

M4NC1O commented Mar 12, 2017

Can anyone please explain me how to solve this problem? I didn't understand what I have to change :)

@dinusuresh
Copy link

dinusuresh commented Mar 12, 2017

@M4NC1O Sure. If you are looking to just get it working, then

In you package.json file make sure the angular2-busy dependency line is like this:
"angular2-busy": "https://github.com/dinusuresh/angular2-busy.git"

remove node_modules folder if you have it

npm cache clean
npm install

@M4NC1O
Copy link

M4NC1O commented Mar 13, 2017

It works!
thank you!

@arianul
Copy link

arianul commented Mar 15, 2017

Thank you !

@Niraj-Sharma
Copy link

It works well..thanks

@M4NC1O
Copy link

M4NC1O commented Mar 15, 2017

When I build --aot I lose the spinner and the label "Loading..".. does anyone have the same issue?

@Niraj-Sharma
Copy link

@dinusuresh: started getting error "DynamicComponentModule is not an NgModule"..

@dinusuresh
Copy link

dinusuresh commented Mar 15, 2017

@Niraj-Sharma Please can you post your package.json and output of npm install?

It is working good on my end, the only warning is the rxjs version 5.0.2 which is used by angular2-dynamic-component

@M4NC1O I will look into it and let you know.

@dinusuresh
Copy link

@Niraj-Sharma #39

@devyumao
Copy link
Owner

devyumao commented Apr 5, 2017

Now the module has been fixed.
Thanks, @dinusuresh ! Your solution is great. 👍
Also thank @superKalo . The issue you mentioned is very helpful.
Sorry for the late reply. The library will be kept updated :)

@devyumao devyumao closed this as completed Apr 5, 2017
@devyumao
Copy link
Owner

devyumao commented Apr 5, 2017

@Niraj-Sharma Now the module does not rely on angular2-dynamic-component any more. Please update to the latest version.

@dinusuresh
Copy link

dinusuresh commented Apr 7, 2017

@devyumao Thank you! Glad to have you back 😄

@PatilPritam
Copy link

Hello,

I followed solution by dinusuresh, but it's not working. Please provide solution.
& also wanted to ask that It will create separate instance for different component if we add in diff component.

Currently, I am using loader with observables but problem is loader gets activated for any request to Server it's just because of service we are using.

Please provide solution.

@PatilPritam
Copy link

@dinusuresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests