Merged
Conversation
📝 WalkthroughWalkthroughThis pull request adds version metadata tracking to the network monitor application. The Dockerfile is enhanced to inject build-time version information (major, minor, patch, commit hash, tree state, and build date) through ldflags during compilation. The application code retrieves this version data and propagates it through the monitor configuration to network traffic metrics requests. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lbagic
approved these changes
Jan 20, 2026
dray92
approved these changes
Jan 20, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@Dockerfile.netmon`:
- Around line 32-40: The GO_VERSION is empty because ${GO_VERSION} is expanded
by the shell before the inline assignment; fix by computing GO_VERSION in the
same shell session before running go build (e.g., run GO_VERSION=$(go version |
awk '{print $3}') && then run CGO_ENABLED=0 ... go build ...) so that the
-ldflags value for github.com/devzero-inc/zxporter/internal/version.goVersion
uses the populated GO_VERSION; update the RUN that invokes go build (referencing
GO_VERSION, go build, and the ldflags key version.goVersion) to perform the
assignment first in the same RUN command.
Comment on lines
+32
to
+40
| RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} GO_VERSION=$(go version | awk '{print $3}') go build \ | ||
| -ldflags "-X github.com/devzero-inc/zxporter/internal/version.major=${MAJOR} \ | ||
| -X github.com/devzero-inc/zxporter/internal/version.minor=${MINOR} \ | ||
| -X github.com/devzero-inc/zxporter/internal/version.patch=${PATCH} \ | ||
| -X github.com/devzero-inc/zxporter/internal/version.gitCommit=${COMMIT_HASH} \ | ||
| -X github.com/devzero-inc/zxporter/internal/version.gitTreeState=${GIT_TREE_STATE} \ | ||
| -X github.com/devzero-inc/zxporter/internal/version.buildDate=${BUILD_DATE} \ | ||
| -X github.com/devzero-inc/zxporter/internal/version.goVersion=${GO_VERSION}" \ | ||
| -a -o zxporter-netmon cmd/zxporter-netmon/main.go |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify that prefixed env vars aren't available during shell expansion
echo "Test 1 - prefixed var (should be empty):"
TEST_VAR=hello echo "Value: ${TEST_VAR}"
echo ""
echo "Test 2 - exported var (should show 'hello'):"
export TEST_VAR=hello && echo "Value: ${TEST_VAR}"Repository: devzero-inc/zxporter
Length of output: 171
🏁 Script executed:
#!/bin/bash
# Simulate Docker's RUN behavior
echo "Test 3 - Docker /bin/sh -c with prefixed var:"
/bin/sh -c 'TEST_VAR=hello echo "Value: ${TEST_VAR}"'
echo ""
echo "Test 4 - Docker /bin/sh -c with export:"
/bin/sh -c 'export TEST_VAR=hello && echo "Value: ${TEST_VAR}"'Repository: devzero-inc/zxporter
Length of output: 171
Shell variable expansion issue: GO_VERSION will be empty in ldflags.
The GO_VERSION=$(...) assignment as an environment variable prefix only affects the environment of go build, but ${GO_VERSION} in the ldflags string is expanded by the shell before the command runs—at which point the variable is unset in the current shell context. This results in goVersion being injected as an empty string at build time.
🔧 Proposed fix
-RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} GO_VERSION=$(go version | awk '{print $3}') go build \
+RUN export GO_VERSION=$(go version | awk '{print $3}') && \
+ CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build \
-ldflags "-X github.com/devzero-inc/zxporter/internal/version.major=${MAJOR} \
-X github.com/devzero-inc/zxporter/internal/version.minor=${MINOR} \
-X github.com/devzero-inc/zxporter/internal/version.patch=${PATCH} \
-X github.com/devzero-inc/zxporter/internal/version.gitCommit=${COMMIT_HASH} \
-X github.com/devzero-inc/zxporter/internal/version.gitTreeState=${GIT_TREE_STATE} \
-X github.com/devzero-inc/zxporter/internal/version.buildDate=${BUILD_DATE} \
-X github.com/devzero-inc/zxporter/internal/version.goVersion=${GO_VERSION}" \
-a -o zxporter-netmon cmd/zxporter-netmon/main.go📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} GO_VERSION=$(go version | awk '{print $3}') go build \ | |
| -ldflags "-X github.com/devzero-inc/zxporter/internal/version.major=${MAJOR} \ | |
| -X github.com/devzero-inc/zxporter/internal/version.minor=${MINOR} \ | |
| -X github.com/devzero-inc/zxporter/internal/version.patch=${PATCH} \ | |
| -X github.com/devzero-inc/zxporter/internal/version.gitCommit=${COMMIT_HASH} \ | |
| -X github.com/devzero-inc/zxporter/internal/version.gitTreeState=${GIT_TREE_STATE} \ | |
| -X github.com/devzero-inc/zxporter/internal/version.buildDate=${BUILD_DATE} \ | |
| -X github.com/devzero-inc/zxporter/internal/version.goVersion=${GO_VERSION}" \ | |
| -a -o zxporter-netmon cmd/zxporter-netmon/main.go | |
| RUN export GO_VERSION=$(go version | awk '{print $3}') && \ | |
| CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build \ | |
| -ldflags "-X github.com/devzero-inc/zxporter/internal/version.major=${MAJOR} \ | |
| -X github.com/devzero-inc/zxporter/internal/version.minor=${MINOR} \ | |
| -X github.com/devzero-inc/zxporter/internal/version.patch=${PATCH} \ | |
| -X github.com/devzero-inc/zxporter/internal/version.gitCommit=${COMMIT_HASH} \ | |
| -X github.com/devzero-inc/zxporter/internal/version.gitTreeState=${GIT_TREE_STATE} \ | |
| -X github.com/devzero-inc/zxporter/internal/version.buildDate=${BUILD_DATE} \ | |
| -X github.com/devzero-inc/zxporter/internal/version.goVersion=${GO_VERSION}" \ | |
| -a -o zxporter-netmon cmd/zxporter-netmon/main.go |
🤖 Prompt for AI Agents
In `@Dockerfile.netmon` around lines 32 - 40, The GO_VERSION is empty because
${GO_VERSION} is expanded by the shell before the inline assignment; fix by
computing GO_VERSION in the same shell session before running go build (e.g.,
run GO_VERSION=$(go version | awk '{print $3}') && then run CGO_ENABLED=0 ... go
build ...) so that the -ldflags value for
github.com/devzero-inc/zxporter/internal/version.goVersion uses the populated
GO_VERSION; update the RUN that invokes go build (referencing GO_VERSION, go
build, and the ldflags key version.goVersion) to perform the assignment first in
the same RUN command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Network operator version configuration
📚 Description of Changes
Provide an overview of your changes and why they’re needed. Link to any related issues (e.g., "Fixes #123"). If your PR fixes a bug, resolves a feature request, or updates documentation, please explain how.
What Changed:
(Describe the modifications, additions, or removals.)
Why This Change:
(Explain the problem this PR addresses or the improvement it provides.)
Affected Components:
(Which component does this change affect? - put x for all components)
Compose
K8s
Other (please specify)
❓ Motivation and Context
Why is this change required? What problem does it solve?
Context:
(Provide background information or link to related discussions/issues.)
Relevant Tasks/Issues:
(e.g., Fixes: #GitHub Issue)
🔍 Types of Changes
Indicate which type of changes your code introduces (check all that apply):
🔬 QA / Verification Steps
Describe the steps a reviewer should take to verify your changes:
make testto verify all tests pass.")make create-kind && make deploy.")✅ Global Checklist
Please check all boxes that apply:
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.