-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.0 #32
Merged
Merged
Version 2.0 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rileytomasek
commented
Oct 22, 2023
•
edited
Loading
edited
- Migrate API to be more inline with OpenAI API/clients
- Improve error handling
- Add jitter to retry timeout
- Remove Zod dependency
- Move to ECMAScript modules and drop CJS build
- Bump minimum Node version to 18
- Upgrade dev dependencies
- Update documentation
Node added native fetch support in v18.
BREAKING: drops support for CJS build - Switch package to ECMAScript modules - Use TypeScript to build and drop esbuild dependency
BREAKING: headers are merged differently. People using custom Ky headers may see different behavior. Use a more standardized way to pass options to Ky.
Now that the OpenAI API has better error handling, we don't need to validate the arguments before making the API request. This makes the library smaller and faster.
This moves much closer the endpoints and shapes of calling the OpenAI API directly, or using the their official Node package.
Better compatibility with the official client. It's also just more comprehensive than what we had.
This allows us to use the official types, without having to make it a dependency and add a ton of weight to the package when installed by someone else (it would get stripped at build even if it was a dep).
rattrayalex
reviewed
Nov 3, 2023
I'd like to merge #37 before publishing v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.