Skip to content

Commit

Permalink
Merge pull request #1609 from PeopleRange/master
Browse files Browse the repository at this point in the history
Fixed mysql EOF issue
  • Loading branch information
Nándor István Krácser authored Jan 6, 2020
2 parents 6318c10 + 98f78db commit 53897e8
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions storage/sql/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,13 @@ func (s *MySQL) open(logger log.Logger) (*conn, error) {
return nil, err
}

if s.MaxIdleConns == 0 {
/*Override default behaviour to fix https://github.com/dexidp/dex/issues/1608*/
db.SetMaxIdleConns(0)
} else {
db.SetMaxIdleConns(s.MaxIdleConns)
}

err = db.Ping()
if err != nil {
if mysqlErr, ok := err.(*mysql.MySQLError); ok && mysqlErr.Number == mysqlErrUnknownSysVar {
Expand Down

0 comments on commit 53897e8

Please sign in to comment.