Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background health check #1399

Open
srenatus opened this issue Feb 6, 2019 · 3 comments
Open

background health check #1399

srenatus opened this issue Feb 6, 2019 · 3 comments

Comments

@srenatus
Copy link
Contributor

srenatus commented Feb 6, 2019

As noted here #1397 (comment), there's more clever approaches we could do. Right now, it'll run the health check every 15 seconds.

I suppose something like an exponential back-off (capped at some max duration) could make sense?

if the first check doesn't succeed, try again in 5s; if it does succeed, try again in 25s; etc

☝️ just a guess, all suggestions are welcome 😃

@soggiest
Copy link

I wouldn't mind taking this on, extending health check retries on subsequent successful attempt makes sense. That being said I propose capping the time limit to a value that makes sense (5 minutes is my initial thought).

@srenatus
Copy link
Contributor Author

@soggiest great, thank you 😃 A five minutes cap seems reasonable, too. (💭 I guess it could be made configurable; but that doesn't have to go into the first iteration.)

@soggiest
Copy link

soggiest commented Feb 13, 2019

/assign @soggiest
Edit: Wow, I'm so used to Prow commands from the kubernetes/kubernetes repo that I assume they're everywhere. I'm leaving this in as a marker of my shame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants