server: update health check endpoint to query storage periodically #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
approved these changes
Feb 4, 2019
Instead of querying the storage every time a health check is performed query it periodically and save the result.
ericchiang
force-pushed
the
health-check-endpoint
branch
from
d7a21b0 to
8935a14
Compare
|
We've already got test coverage but I added a negative test :) |
|
LGTM. Thanks! :)
…On Mon, 4 Feb 2019, 20:04 Eric Chiang ***@***.*** wrote:
We've already got test coverage but I added a negative test :)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1397 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA1I7lfVJh7tF6Pp-NrzctpfM1Cbq2MKks5vKIRTgaJpZM4ahuFq>
.
|
|
💭 I guess making the 15s configurable would be a good first PR |
|
Instead of exposing a knob maybe we could choose a better value? Or lower the frequency when the health check isn't queried :) |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
server: update health check endpoint to query storage periodically
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of querying the storage every time a health check is performed
query it periodically and save the result.
Updates #1386