Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client secrets must be base64 encoded in --no-db mode #337

Closed
ericchiang opened this issue Feb 24, 2016 · 1 comment
Closed

client secrets must be base64 encoded in --no-db mode #337

ericchiang opened this issue Feb 24, 2016 · 1 comment
Labels
kind/cleanup priority/Pmaybe

Comments

@ericchiang
Copy link
Contributor

Using the SQL code for --no-db mode exposed the fact that the SQL code assumes that client secrets are base64 decodable: https://github.com/coreos/dex/blob/f51125f55538c8fc5a3ad1e780296fd505fb948d/db/client.go#L206

Is there anyway we can get around this?
@fnordahl fnordahl mentioned this issue Feb 26, 2016
Closed
ericchiang added a commit to ericchiang/dex that referenced this issue Apr 11, 2016
@ericchiang
db: print better error messages for invalid input
5c5df23 
When client secrets are not base64 encoded, print an error message
that's not a generic base64 decode error:

   client secrets must be base64 decodable. See issue dexidp#337.
   Please consider replaceing "secret" with "c2VjcmV0"

When a user file is missing a mandatory field print an error message.

	Unable to build Server: user elroy-foo is missing email field

For dexidp#400
This was referenced Aug 10, 2016
Merged
Merged
@ericchiang
Copy link
Contributor Author

Client secrets no longer have encoding issuers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup priority/Pmaybe
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobbyrullo @ericchiang