Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick icons on login screen by connector type instead of ID #1576

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

nabokihms
Copy link
Member

We are picking icons by provider ID. For example:

  1. User can type anything into ID field.
  2. ID field don't match any css class name with icon
  3. User have no icon even if he picked provider with predefined icon (github, gitlab, etc.)

Using type field will make user always have icons for all providers on login screen.
Because we know all possible provider types and can prepare icons for them.

Only icons that don't fit into the logic now is google-icon.svg and coreos-icon.svg.

Signed-off-by: m.nabokikh maksim.nabokikh@flant.com

@jenting
Copy link

jenting commented Nov 12, 2019

With this PR change, how to deals with multiple LDAP connectors?

@sagikazarmark
Copy link
Member

Only icons that don't fit into the logic now is google-icon.svg and coreos-icon.svg.

That's not quite true. There is a google provider now.

With this PR change, how to deals with multiple LDAP connectors?

This PR only changes the logo, but not the provider name, so I think it should continue working just fine.

@nabokihms can you please rebase your branch from master to make GitHub actions happy?

@jenting
Copy link

jenting commented Dec 19, 2019

With this PR change, how to deals with multiple LDAP connectors?

This PR only changes the logo, but not the provider name, so I think it should continue working just fine.

Thanks, I got the point ;)

Copy link

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabokihms
Copy link
Member Author

@sagikazarmark rebased :)

Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nabokihms !

There is one small thing I would change, otherwise it is good to go. Good catch!

server/handlers.go Show resolved Hide resolved
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nabokihms !

@sagikazarmark sagikazarmark merged commit 789272a into dexidp:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants