Use constants to form oauth2 error responses #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
nabokihms
changed the title
nabokihms
changed the title
sagikazarmark
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: m.nabokikh maksim.nabokikh@flant.com
Overview
What this PR does / why we need it
According to https://tools.ietf.org/html/rfc6749#section-3.1.1, the state
invalid_requestsis invalid (and it looks like a typo).To avoid similar errors in the future, this PR replaces all state arguments with constants.
Special notes for your reviewer
Correct error on empty response_type is required to pass the OpenID certification.
Does this PR introduce a user-facing change?
The only user-facing change is replacing invalid_requests with invalid_request.