Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update max length of kubernetes object to fit kubernetes policy #3439

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

RomanenkoDenys
Copy link
Contributor

https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-subdomain-names

Overview

Update max length of kubernetes object to fit kubernetes policy.

What this PR does / why we need it

We faced an errror with oauth2 clients with id longer than 63 symbols (77 in particular).

Special notes for your reviewer

{"level":"error","msg":"Failed to get client: invalid kubernetes resource name: must match the pattern ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and be no longer than 63 characters","time":"2024-03-28T19:20:09Z"}
{"level":"error","msg":"Failed to parse authorization request: Database error.","time":"2024-03-28T19:20:09Z"}

Signed-off-by: Maksim Nabokikh <max.nabokih@gmail.com>
@nabokihms nabokihms self-requested a review March 28, 2024 19:58
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Probably worth backporting.

@nabokihms nabokihms merged commit 7225198 into dexidp:master Mar 28, 2024
9 checks passed
nabokihms added a commit to deckhouse/3p-dex that referenced this pull request Apr 9, 2024
…dp#3439)

Signed-off-by: Denys Romanenko <65756796+RomanenkoDenys@users.noreply.github.com>
Signed-off-by: Maksim Nabokikh <max.nabokih@gmail.com>
Co-authored-by: Maksim Nabokikh <max.nabokih@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants