Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the default cosign version from the action #3458

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Apr 8, 2024

Overview

  • use the default cosign version from the action

not pinning the cosign version helps to be always up-to-date and depends only in the action update

What this PR does / why we need it

Special notes for your reviewer

Signed-off-by: cpanato <ctadeu@gmail.com>
@sagikazarmark
Copy link
Member

Is it pinned in the action? I've burnt myself with silent upgrades more than I care to admit.

@cpanato
Copy link
Contributor Author

cpanato commented Apr 8, 2024

Is it pinned in the action? I've burnt myself with silent upgrades more than I care to admit.

yes, it is pinned, but if you want to do another PR to update the cosign version is fine as well, just trying to reduce the overhead

@sagikazarmark sagikazarmark added the release-note/dependency-update Release note: Dependency Updates label Apr 9, 2024
@sagikazarmark
Copy link
Member

yes, it is pinned

That's enough for me

@sagikazarmark sagikazarmark merged commit a3d3f3b into dexidp:master Apr 9, 2024
9 of 10 checks passed
@cpanato cpanato deleted the update-cosign branch April 9, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/dependency-update Release note: Dependency Updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants