-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new Prometheus metrics build_info #3558
Conversation
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestion to make the metrics match Kubernetes build info labels:
go_version
instead ofgoversion
(for readability)platform
instead ofgoarch
, because this label is usually used to understand where you can run the software
Overall, PR looks great! Thanks for your effort.
cmd/dex/serve.go
Outdated
Namespace: "dex", | ||
Help: "A metric with a constant '1' value labeled by version from which Dex was built.", | ||
}, | ||
[]string{"version", "goversion", "goarch"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[]string{"version", "goversion", "goarch"}, | |
[]string{"version", "go_version", "platform"}, |
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault could you please fix the lint error? |
I don't know how to fix that:
|
It should help:
|
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Overview
Add a new metric
dex_build_info
, withversion
which will be set to the Git tag version.What this PR does / why we need it
Special notes for your reviewer