Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich Dex logs with real IP and request ID #3661

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

nabokihms
Copy link
Member

Overview

  • Include client's real IP in logs.
  • Capture and log unique request IDs.
  • Update middleware to extract and forward this data.
  • Enhance debugging and traceability. Improves insight and troubleshooting efficiency.

What this PR does / why we need it

#1788

Special notes for your reviewer

@nabokihms nabokihms added the release-note/new-feature Release note: Exciting New Features label Jul 30, 2024
- Include client's real IP in logs.
- Capture and log unique request IDs.
- Update middleware to extract and forward this data.
- Enhance debugging and traceability.
Improves insight and troubleshooting efficiency.

Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms nabokihms force-pushed the real-ip-header-dex branch from 4e2efb5 to ac1c12b Compare July 30, 2024 19:58
@nabokihms nabokihms marked this pull request as ready for review July 30, 2024 19:59
@nabokihms nabokihms requested a review from sagikazarmark July 30, 2024 19:59
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple suggestions

cmd/dex/config.go Outdated Show resolved Hide resolved
cmd/dex/config.go Show resolved Hide resolved
cmd/dex/config.go Show resolved Hide resolved
cmd/dex/config.go Outdated Show resolved Hide resolved
server/server.go Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
nabokihms and others added 2 commits July 31, 2024 12:18
Co-authored-by: Márk Sági-Kazár <sagikazarmark@users.noreply.github.com>
Signed-off-by: Maksim Nabokikh <max.nabokih@gmail.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms nabokihms requested a review from sagikazarmark July 31, 2024 10:25
@nabokihms nabokihms merged commit 2256607 into dexidp:master Aug 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/new-feature Release note: Exciting New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants