feat: Add retry mechanism for storage initialization #3701
+225
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoeBensu
force-pushed
the
feat/add-storage-retry-mechanism
branch
from
e050033
to
b1762c8
Compare
MoeBensu
force-pushed
the
feat/add-storage-retry-mechanism
branch
7 times, most recently
from
cdb76ff
to
6ad2c32
Compare
MoeBensu
changed the title
MoeBensu
force-pushed
the
feat/add-storage-retry-mechanism
branch
from
a091d04
to
eb7b854
Compare
MoeBensu
force-pushed
the
feat/add-storage-retry-mechanism
branch
from
2b5b88b
to
8adc2c4
Compare
Signed-off-by: moeneuron <m.binsumait@pm.me>
Signed-off-by: moeneuron <m.binsumait@pm.me>
Signed-off-by: moeneuron <m.binsumait@pm.me>
MoeBensu
force-pushed
the
feat/add-storage-retry-mechanism
branch
from
8adc2c4
to
255cce4
Compare
|
@nabokihms I would like to request a review here, if possible! Or how do you like to plan this in the next release? |
nabokihms
requested changes
Aug 28, 2024
cmd/dex/serve.go
Outdated
Comment on lines
698
to
706
| retryAttempts := storageConfig.RetryAttempts | ||
| if retryAttempts == 0 { | ||
| retryAttempts = 5 // Default to 5 attempts | ||
| } | ||
|
|
||
| retryDelay, err := time.ParseDuration(storageConfig.RetryDelay) | ||
| if err != nil { | ||
| retryDelay = 5 * time.Second // Default to 5 seconds | ||
| } |
There was a problem hiding this comment.
Let's move this code to the config parsing, we usually enforce config default there, not in the method. I expect it to be in cmd/dex/config.go
cmd/dex/config.go
Outdated
Comment on lines
259
to
260
| RetryAttempts int `json:"retryAttempts"` | ||
| RetryDelay string `json:"retryDelay"` |
There was a problem hiding this comment.
- Probably it is better to use token/bucket algorithm or an exponential backoff.
- Let's put options under a single key
retry:
attempts: 3
delay: 5s
cmd/dex/config.go
Outdated
| Type string `json:"type"` | ||
| Config json.RawMessage `json:"config"` | ||
| RetryAttempts int `json:"retryAttempts"` | ||
| RetryDelay string `json:"retryDelay"` |
There was a problem hiding this comment.
Do we need to validate here that delay is in the go time format, e.g., 5s, 10m?
MoeBensu
force-pushed
the
feat/add-storage-retry-mechanism
branch
from
9161a5f
to
5baca04
Compare
|
connected #1189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3602
PR includes: